Proper loops - #9329
Closed
JMS55 wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
I tested in a Bevy scene on Windows+Nvidia. Was not any faster. Would love if more people could test on other platforms and shaders. |
Contributor
|
GPU profiling data for mac reveals no conclusive results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #6521 and #4499
Description
Naga used to translate all for/while loops into while(true) loops, which hurt performance. This PR fixes that.
Disclaimer: Heavily LLM generated. I've done my best to review line-by-line, and I'm mostly confident in everything except the code that actually writes for/while loops for each backend.
Testing
Ran all existing naga tests, and eyeballed the generated shader diffs.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.