Fix debug_assert in dx12 indirect multi draw - #9332
Merged
Merged
Conversation
ErichDonGubler
left a comment
ErichDonGubler
left a comment
Member
There was a problem hiding this comment.
Before we merge, will you please add a CHANGELOG entry? 🙏🏻
kristoff3r
force-pushed
the
ks/indirect_stride
branch
from
March 31, 2026 16:30
f4e7eb3 to
54b96a1
Compare
Contributor
Author
Done! |
ErichDonGubler
added
backend: dx12
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
May 1, 2026
cwfitzgerald
removed
the
PR: needs back-porting
slyedoc
pushed a commit
to slyedoc/wgpu
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7955 (and bevyengine/bevy#23220)
Description
The stride validation was calculated incorrectly in dx12. I fixed it by refactoring a bit to make it more clear that the strides can differ, and that the destination stride is backend dependent.
Testing
I refactored the existing draw_indirect test to also cover multi draw, and I tested it without the fix on my Windows and could reproduce the issue. I'm not sure if this is the testing you had in mind.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.