fix(core): Fix resource usage for R/O depth w/o TEXTURE_BINDING - #9346
Merged
Conversation
andyleiserson
force-pushed
the
jj-push-wwwu
branch
from
March 31, 2026 01:39
429db8a to
95924b8
Compare
andyleiserson
force-pushed
the
jj-push-wwwu
branch
from
March 31, 2026 01:52
95924b8 to
c8a1af5
Compare
slyedoc
pushed a commit
to slyedoc/wgpu
that referenced
this pull request
May 28, 2026
…rs#9346) * fix(core): Fix resource usage for R/O depth w/o TEXTURE_BINDING Fixes gfx-rs#9343 * Update test and waive failure Related to gfx-rs#5231 * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9343 a.k.a. Firefox bug 1987462.
When opening a render pass with a read-only depth attachment, wgpu automatically applies
TextureUses::RESOURCEin addition toTextureUses::DEPTH_STENCIL_READ. These are compatible usages, and most of the time this did not cause a problem, but if the texture view does not haveTextureUsages::TEXTURE_BINDING, dx12 will raise an error that the resource cannot be transitioned to the states associated withTextureUses::RESOURCE.Testing
Adds a regression test as a GPU test. The test can also serve as a regression test for #5231 (which remains an issue, so the test is marked as expect-fail on Vulkan).
Squash or Rebase? Squash
Checklist
CHANGELOG.mdentry.