Make vertex buffer slots optional - #9351
Merged
Merged
Conversation
teoxoy
force-pushed
the
null-vertex-buffers
branch
from
March 31, 2026 19:59
30ad17b to
bd87a84
Compare
andyleiserson
approved these changes
Apr 10, 2026
andyleiserson
left a comment
andyleiserson
left a comment
Contributor
There was a problem hiding this comment.
Nice! Just a few nits.
teoxoy
force-pushed
the
null-vertex-buffers
branch
from
April 13, 2026 15:59
bd87a84 to
dbecf92
Compare
teoxoy
force-pushed
the
null-vertex-buffers
branch
from
April 14, 2026 13:30
dbecf92 to
484f03c
Compare
teoxoy
force-pushed
the
null-vertex-buffers
branch
from
April 14, 2026 13:47
484f03c to
e260948
Compare
render bundles - render passes now defer setting vertex buffers to the start of a draw command (same as bundles) - render bundles now cache vertex/instance limit calculations when setting the pipeline or when setting a vertex buffer (same as passes)
teoxoy
force-pushed
the
null-vertex-buffers
branch
from
April 14, 2026 16:10
59f943c to
f6e06c8
Compare
teoxoy
force-pushed
the
null-vertex-buffers
branch
from
April 14, 2026 16:15
f6e06c8 to
d400575
Compare
andyleiserson
approved these changes
Apr 15, 2026
andyleiserson
left a comment
andyleiserson
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing the additional cleanup.
7 tasks
pull Bot
pushed a commit
to CrazyForks/bevy
that referenced
this pull request
Jul 16, 2026
# Objective Upgrade to [wgpu 30](https://github.com/gfx-rs/wgpu/releases/tag/v30.0.0) ## Solution - [x] Update and merge [naga_oil](bevyengine/naga_oil#139) - [x] Publish naga_oil - [x] Update and merge [dlss_wgpu](bevyengine/dlss_wgpu#31) - [x] publish dlss_wgpu - [x] remove dependency patches for naga_oil and dlss_wgpu ### Relevant Changes - new NoopBackendOptions fields: gfx-rs/wgpu#9119 - SurfaceColorSpace: gfx-rs/wgpu#9658 - get_mapped_range returns a Result: gfx-rs/wgpu#9281 - empty BufferSlices no longer panic: gfx-rs/wgpu#8505 - vertex buffer slots are optional now: gfx-rs/wgpu#9351 - `SurfaceTexture::present()` has been replaced by `Queue::present(surface_texture)`: gfx-rs/wgpu#9361 - Disallow direct access to atomic variables in WGSL front-end (e.g. let x = myAtomic;) gfx-rs/wgpu#9262. (affects solari) ## Testing - [x] 3d_scene - [x] solari with dlss ## Showcase #### 3d_scene on macos <img width="1728" height="1084" alt="image" src="https://github.com/user-attachments/assets/5ce80506-6924-4359-b469-92c32f06a505" /> #### ssao on macos <img width="1728" height="1084" alt="image" src="https://github.com/user-attachments/assets/8302ead7-54dc-44f9-8e71-a619d96c499e" /> #### bevy_city on macos <img width="1728" height="1084" alt="image" src="https://github.com/user-attachments/assets/4db1eba7-1c9b-4c54-95fe-1dc42ffc0e9e" /> #### Solari on Windows 11 <img width="1282" height="752" alt="image" src="https://github.com/user-attachments/assets/2a367a06-f167-4b73-a781-6a2c5e4065dd" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7354.
Fixes #8832.
Fixes #7912.
Description
Makes vertex buffer slots optional.
Testing
Enabled more CTS tests.
Squash or Rebase?
Rebase.