Skip to content

refactor!: subvert-rename dispatch* to dispatchWorkGroups* - #9362

Merged
Wumpf merged 1 commit into
gfx-rs:trunkfrom
erichdongubler-mozilla:erichdongubler-push-silly-sparkling-donkey
Apr 11, 2026
Merged

refactor!: subvert-rename dispatch* to dispatchWorkGroups*#9362
Wumpf merged 1 commit into
gfx-rs:trunkfrom
erichdongubler-mozilla:erichdongubler-push-silly-sparkling-donkey

Conversation

@ErichDonGubler

Copy link
Copy Markdown
Member

Connections

Refactored while doing the work to understand #8946, but only tangentially related.

Description

Standard WebGPU's GPUComputePassEncoder uses dispatchWorkgroups* as the prefix for its dispatch operations, rather than just dispatch*. Make wgpu match!

Testing

it compile 👁️👄👁️

Squash or Rebase?

Squash, please!

Checklist

  • If this contains user-facing changes, add a CHANGELOG.md entry.

@ErichDonGubler
ErichDonGubler force-pushed the erichdongubler-push-silly-sparkling-donkey branch from c14af30 to 5390496 Compare April 2, 2026 20:23
@ErichDonGubler ErichDonGubler added area: api Issues related to API surface kind: refactor Making existing function faster or nicer labels Apr 2, 2026
@ErichDonGubler
ErichDonGubler force-pushed the erichdongubler-push-silly-sparkling-donkey branch from 5390496 to 21fcf41 Compare April 2, 2026 20:24
@ErichDonGubler
ErichDonGubler marked this pull request as ready for review April 2, 2026 20:25
@ErichDonGubler
ErichDonGubler force-pushed the erichdongubler-push-silly-sparkling-donkey branch 2 times, most recently from b8ad161 to 0ed85d5 Compare April 3, 2026 17:22
@Wumpf Wumpf self-assigned this Apr 8, 2026
@Wumpf
Wumpf self-requested a review April 8, 2026 15:17
Wumpf
Wumpf previously requested changes Apr 8, 2026

@Wumpf Wumpf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something unrelated slipped in?
otherwise lgtm!

Comment thread wgpu-types/src/size.rs Outdated
@ErichDonGubler
ErichDonGubler force-pushed the erichdongubler-push-silly-sparkling-donkey branch from 0ed85d5 to 86affaf Compare April 8, 2026 21:58
@ErichDonGubler
ErichDonGubler requested a review from Wumpf April 8, 2026 21:59
@ErichDonGubler
ErichDonGubler force-pushed the erichdongubler-push-silly-sparkling-donkey branch from 86affaf to a902a77 Compare April 8, 2026 22:00
@ErichDonGubler

Copy link
Copy Markdown
Member Author

Force-pushed to resolve a conflict with CHANGELOG.md.

@kpreid

kpreid commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

What does “subvert” mean in the PR title? (And "!"?)

@ErichDonGubler

ErichDonGubler commented Apr 9, 2026

Copy link
Copy Markdown
Member Author

What does “subvert” mean in the PR title? …

It's an old term from the Vim world, specifically abolish.vim, which uses Subvert as the command for case-independent renames (i.e., it analyzes segments from input's case so that we correctly rename snake-case, kebab_case, PascalCase, etc.). I don't expect most folk to immediately understand it; it's more friendly for commit message headers than anything. I've never heard of another term for this, but I'm open to suggestion for something more accessible (and hopefully just as pithy)!

@ErichDonGubler

Copy link
Copy Markdown
Member Author

What does … (… "!" [mean]?)

This is a Conventional Commit concept that indicates a breaking change.

@ErichDonGubler
ErichDonGubler force-pushed the erichdongubler-push-silly-sparkling-donkey branch from a902a77 to 2c13b85 Compare April 9, 2026 15:19
@ErichDonGubler

Copy link
Copy Markdown
Member Author

@Wumpf: Your feedback should be resolved now! 🙏🏻

@Wumpf
Wumpf merged commit 10ce22b into gfx-rs:trunk Apr 11, 2026
59 checks passed
slyedoc pushed a commit to slyedoc/wgpu that referenced this pull request May 28, 2026
@ErichDonGubler
ErichDonGubler deleted the erichdongubler-push-silly-sparkling-donkey branch June 24, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: api Issues related to API surface kind: refactor Making existing function faster or nicer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants