feat(wgpu-hal/dx12): add raw_resource method to Buffer - #9364
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a DX12-specific escape hatch to access the underlying ID3D12Resource for wgpu-hal’s dx12::Buffer, matching existing raw access patterns used elsewhere in the backend.
Changes:
- Add
Buffer::raw_resource()to expose the underlyingDirect3D12::ID3D12Resource.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Wumpf
approved these changes
Apr 8, 2026
Wumpf
left a comment
Member
There was a problem hiding this comment.
looks like we already have this pattern on Texture, so whatever I don't like about it would also apply here, but that would make it a bigger question and this just makes it consistent 🤷 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow accessing
ID3D12Resourceof Buffer.Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.