Implement `texture-component-swizzle` by beicause · Pull Request #9553 · gfx-rs/wgpu

beicause · 2026-05-14T18:04:51Z

Connections
Fixes #1028.

Description
Implementn texture component swizzle feature on vulkan, metal and dx12 (not implemented on gles)

Testing
I added texture component swizzle CTS

cargo xtask cts 'webgpu:api,operation,texture_view,texture_component_swizzle:*'

Squash or Rebase?
Squash

Checklist

I self-reviewed and fully understand this PR.
WebGPU implementations built with wgpu may be affected behaviorally.
Validation and feature gates are in place to confine behavioral changes.
Tests demonstrate the validation and altered logic works.
CHANGELOG.md entries for the user-facing effects of this change are present.
The PR is minimal, and doesn't make sense to land as multiple PRs.
Commits are logically scoped and individually reviewable.
The PR description has enough context to understand the motivation and solution implemented.

…swizzle

…l texture without shader usage

…swizzle

inner-daemons · 2026-06-07T05:28:39Z

Agh same here, another long delay. Will also prioritize this PR early this week

inner-daemons

I'm tired so not everything I wrote will be coherent or correct. Please ask if you are not sure what I mean anywhere.

This is a useful feature but there are some behavioral changes, particularly on metal, that need to be justified.

Sorry for the delay, hopefully my next review will be quicker.

inner-daemons · 2026-06-15T07:02:37Z

+        /// - Metal on Apple2+ or Mac2+
+        ///
+        /// Not yet implemented:
+        /// - OpenGL


Can you note whether it would be possible on OpenGL

OpenGL has glTexParameter GL_TEXTURE_SWIZZLE_*

Ok, maybe file an issue and link it in the feature docs

This remains to be done I think

inner-daemons · 2026-06-15T07:16:59Z

-        usage.intersects(
-            Tu::RESOURCE | Tu::DEPTH_STENCIL_READ | Tu::STORAGE_READ_ONLY | Tu::STORAGE_READ_WRITE,
-        ),
+        usage.intersects(Tu::RESOURCE | Tu::STORAGE_READ_ONLY | Tu::STORAGE_READ_WRITE),


This is a weird change, can you explain?

This is needed by https://github.com/beicause/wgpu/blob/0fb4f24f52e432174057ddc63c9f6e3a3d63285e/wgpu-hal/src/metal/device.rs#L632-L635

I think DEPTH_STENCIL_READ doesn't require ShaderRead. Only DEPTH_STENCIL_READ|RESOURCE (RENDER_ATTACHMENT|TEXTURE_BINDING) together requires ShaderRead.

inner-daemons · 2026-06-15T07:20:37Z

+                    at_descriptor.setTexture(Some(&at.target.view.attachment.texture));
+                    at_descriptor.setLevel(at.target.view.attachment.base_mip_level as _);
+                    at_descriptor.setSlice(at.target.view.attachment.base_array_layer as _);


Why is this change necessary? It warrants some comments in code

I commented in https://github.com/beicause/wgpu/blob/0fb4f24f52e432174057ddc63c9f6e3a3d63285e/wgpu-hal/src/metal/device.rs#L708-L709

When used as a texture binding, depth-stencil needs to use the r001 view, but when used as an attachment, depth-stencil cannot use the swizzled view because it's non-renderable. This is a problem if depth-stencil texture has both RENDER_ATTACHMENT and TEXTURE_BINDING, so we always use the original texture + setLevel/setSlice to avoid the non-renderable view.

…swizzle

inner-daemons

Vast majority of comments are the same renames. Im not super attached to the names I chose but I definitely think they are an improvement.

Nothing here that should be blocking.

Apologies again for the delay, lets try to get this in soon!

inner-daemons · 2026-07-10T20:11:46Z

  }
 }
+
+fn map_texture_component_swizzle(


Suggested change

fn map_texture_component_swizzle(

fn map_all_texture_components_swizzle(

The function names are following the structs TextureComponentSwizzle ComponentSwizzle.

Perhaps the structs should be renamed, but I haven't thought of better names yet.

Yes I think they should be renamed, since it is not immediatley clear which is which or why IMO.

Current names is from webgpu.h:
WGPUTextureComponentSwizzle
WGPUComponentSwizzle

Interesting. I wonder why they made that decision. Regardless, you can ignore all my comments on this topic

The alternative names I thought of are TextureSwizzle + Swizzle which are shorter with "Component" omitted

But I'll wait for more feedback if we want to change them.

Edit: But webgpu already used texture_component_swizzle everywhere so probably we should stick to TextureComponentSwizzle?

inner-daemons · 2026-07-10T20:12:00Z

+  Ok(wgpu_types::TextureComponentSwizzle { r, g, b, a })
+}
+
+fn map_component_swizzle(


Suggested change

fn map_component_swizzle(

fn map_texture_component_swizzle(

inner-daemons · 2026-07-10T20:44:42Z

+        /// - Metal on Apple2+ or Mac2+
+        ///
+        /// Not yet implemented:
+        /// - OpenGL


This remains to be done I think

…swizzle

inner-daemons · 2026-07-12T03:33:06Z

Can you ping me or request a re-review when you think I should take another look?

Co-authored-by: Inner Daemons <85136135+inner-daemons@users.noreply.github.com>

inner-daemons

Assuming you haven't changed anything major since my last review, approving. Sorry once again for the delay.

…swizzle

beicause force-pushed the texture-component-swizzle branch from 56c7392 to a1c8647 Compare May 15, 2026 06:54

beicause changed the title ~~(WIP) Implement texture-component-swizzle~~ Implement texture-component-swizzle on Vulkan May 15, 2026

This comment was marked as resolved.

Sign in to view

beicause force-pushed the texture-component-swizzle branch from a1c8647 to b397976 Compare May 15, 2026 07:24

beicause marked this pull request as ready for review May 15, 2026 07:25

beicause changed the title ~~Implement texture-component-swizzle on Vulkan~~ Implement texture-component-swizzle on Vulkan and DX12 May 15, 2026

beicause added 5 commits May 15, 2026 23:32

Implement texture-component-swizzle

352c3e9

Revert dx12 and metal changes

364de23

Add changelog

dfad641

Better chars to TextureComponentSwizzle

2ea0e4e

Restore dx12

2c7fad6

beicause force-pushed the texture-component-swizzle branch 2 times, most recently from 9533b09 to 226392c Compare May 15, 2026 16:40

cts: Disable dx12 texture_component_swizzle with depth comparison

64b2ed3

beicause force-pushed the texture-component-swizzle branch from 226392c to 64b2ed3 Compare May 17, 2026 02:03

beicause added 3 commits May 17, 2026 12:41

(TODO) Fix metal

8f9bf4e

Fix metal

4af2f17

Merge remote-tracking branch 'upstream/trunk' into texture-component-…

9389649

…swizzle

beicause changed the title ~~Implement texture-component-swizzle on Vulkan and DX12~~ Implement texture-component-swizzle May 18, 2026

beicause added 2 commits May 18, 2026 10:33

Add comments

87a62a4

metal: don't require type_equal&&range_full_resource to use origina…

00409a6

…l texture without shader usage

beicause commented May 19, 2026

View reviewed changes

Comment thread cts_runner/test.lst Outdated

inner-daemons self-requested a review May 20, 2026 15:31

inner-daemons self-assigned this May 20, 2026

Wumpf unassigned inner-daemons May 27, 2026

jimblandy self-assigned this May 27, 2026

Wumpf assigned inner-daemons May 27, 2026

Merge remote-tracking branch 'upstream/trunk' into texture-component-…

6c43c56

…swizzle

beicause force-pushed the texture-component-swizzle branch from 9e12d46 to 9a25432 Compare May 28, 2026 01:53

Simplify test.lst

0fb4f24

beicause force-pushed the texture-component-swizzle branch from 9a25432 to 0fb4f24 Compare May 28, 2026 01:56

inner-daemons suggested changes Jun 15, 2026

View reviewed changes

beicause added 6 commits June 16, 2026 13:59

vk: check portability subset swizzle feature

06aaf1e

Improve comments

7e751bc

Merge remote-tracking branch 'upstream/trunk' into texture-component-…

e1b11d4

…swizzle

Fix doctest

7d7bf6f

vk: add missing image_view_format_swizzle

afcccc2

metal: allow metal3

1898e6a

inner-daemons requested review from inner-daemons and jimblandy July 8, 2026 15:16

inner-daemons suggested changes Jul 10, 2026

View reviewed changes

beicause added 5 commits July 11, 2026 11:27

Merge remote-tracking branch 'upstream/trunk' into texture-component-…

89fa140

…swizzle

Fix merge

19aaf7c

Use ArrayString in webgpu backend

7d3b3c7

refactor deno map_texture_component_swizzle

56311a9

readd component swizzle cts on dx12

5f9822b

Update wgpu-hal/src/metal/device.rs

9fe1e6c

Co-authored-by: Inner Daemons <85136135+inner-daemons@users.noreply.github.com>

beicause requested a review from inner-daemons July 12, 2026 05:35

inner-daemons approved these changes Jul 27, 2026

View reviewed changes

beicause added 2 commits July 31, 2026 16:19

Merge remote-tracking branch 'upstream/trunk' into texture-component-…

f626a44

…swizzle

Fix merge

33e3a16

beicause force-pushed the texture-component-swizzle branch from cef3286 to 33e3a16 Compare July 31, 2026 09:08

	fn map_texture_component_swizzle(
	fn map_all_texture_components_swizzle(

Uh oh!

Conversation

beicause commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

inner-daemons commented Jun 7, 2026

Uh oh!

inner-daemons left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beicause Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inner-daemons left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beicause Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inner-daemons commented Jul 12, 2026

Uh oh!

inner-daemons left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

beicause commented May 14, 2026 •

edited

Loading

beicause Jun 15, 2026 •

edited

Loading

beicause Jul 12, 2026 •

edited

Loading