docs: correct BlasAabbGeometry stride reference and document AABB layout - #9934
Merged
Vecvec merged 1 commit intoJul 25, 2026
Merged
Conversation
mstampfli
force-pushed
the
docs/aabb-geometry-stride-and-layout
branch
2 times, most recently
from
July 23, 2026 06:15
3f8e698 to
1929b28
Compare
The BlasAabbGeometry doc referred to a size.stride field, but BlasAABBGeometrySizeDescriptor has no stride; the stride lives on BlasAabbGeometry itself. Point the docs at the right field and, while there, document the packed AABB buffer layout (each primitive is a minimum then a maximum corner, two consecutive vec3<f32>, the 24-byte AABB_GEOMETRY_MIN_STRIDE) which was only implied before.
mstampfli
force-pushed
the
docs/aabb-geometry-stride-and-layout
branch
from
July 23, 2026 06:22
1929b28 to
c1b3bad
Compare
Vecvec
approved these changes
Jul 25, 2026
Vecvec
left a comment
Vecvec
left a comment
Contributor
There was a problem hiding this comment.
#9290 previously had a size.stride, but it was removed, I guess that change didn't carry over to the docs.
Nice to have the layout specified on the buffer as well as on AABB_GEOMETRY_MIN_STRIDE (which is probably more out of the way).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
None.
Description
BlasAabbGeometry's documentation referred to asize.stridefield, butBlasAABBGeometrySizeDescriptor(thesizesub-descriptor) has nostridefield - the stride lives onBlasAabbGeometryitself. This fixes the two stale references and documents the packed AABB buffer layout (minimum then maximum corner, two consecutivevec3<f32>, the 24-byteAABB_GEOMETRY_MIN_STRIDE), which was previously only implied by theray_aabb_computeexample.Testing
Documentation only, no code change;
cargo fmtclean and the docs build.Squash or Rebase?
Squash.