Skip to content

Optimise Tlas building - #9961

Open
Vecvec wants to merge 7 commits into
gfx-rs:trunkfrom
Vecvec:tlas-build-optimise
Open

Optimise Tlas building#9961
Vecvec wants to merge 7 commits into
gfx-rs:trunkfrom
Vecvec:tlas-build-optimise

Conversation

@Vecvec

@Vecvec Vecvec commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Connections
First step on #9946

Description
Some low hanging fruit optimisations which save a few miliseconds (total ~7 ms in an initially 17-19 ms function)

Testing
existing tests should cover this

Squash or Rebase?

Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@Vecvec
Vecvec force-pushed the tlas-build-optimise branch from 07394fa to 7a71f3a Compare July 29, 2026 08:52

@kpreid kpreid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know much about ray tracing or this part of the code, so here are a couple of comments aimed at improving the comprehensibility of the code.

Comment thread wgpu-core/src/command/ray_tracing.rs Outdated
Comment thread wgpu-core/src/command/ray_tracing.rs Outdated
Comment thread wgpu-core/src/command/ray_tracing.rs Outdated
@inner-daemons
inner-daemons self-requested a review July 29, 2026 15:52
@Vecvec
Vecvec force-pushed the tlas-build-optimise branch 3 times, most recently from ba565d1 to 6179c92 Compare July 31, 2026 19:37
@Vecvec
Vecvec force-pushed the tlas-build-optimise branch from 6179c92 to db90b90 Compare August 3, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants