feat(core): Expose descriptor validation separately from request_device - #9967
Merged
Conversation
ErichDonGubler
approved these changes
Jul 30, 2026
ErichDonGubler
added
area: api
Member
|
don't forget the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the descriptor-validation function of
request_deviceseparately as avalidate_device_descriptorAPI, so that it can still be used even if device creation itself is using hal directly.Testing
Simple refactor, but also tested locally
Squash or Rebase? Squash
Checklist
CHANGELOG.mdentries for the user-facing effects of this change are present.