Add textureSampleLevel:sampled_{1,2,3}d coverage in CTS - #9975
Draft
ErichDonGubler wants to merge 6 commits into
Draft
Add textureSampleLevel:sampled_{1,2,3}d coverage in CTS#9975ErichDonGubler wants to merge 6 commits into
textureSampleLevel:sampled_{1,2,3}d coverage in CTS#9975ErichDonGubler wants to merge 6 commits into
Conversation
Addresses @ErichDonGubler's review. writer.rs: use TypeInner::vector_size_and_scalar instead of re-implementing the match, switch debug_assert_eq! to assert_eq!, and hoist the DXC issue comment above the workaround block where it explains the whole thing. CHANGELOG.md: take the suggested wording, imperative and scoped to all non-2D textures rather than just 3D. cts_runner/test.lst: add the 1D and 3D textureSampleLevel execution selectors, the non-2D dimensionalities whose offset constructor was wrong. Verified locally: sampled_3d_coords 3357 pass / 0 fail, sampled_1d_coords 972 pass / 0 fail. Those ran on Metal, so CI's Windows runner is what actually exercises the HLSL backend this fix touches.
ErichDonGubler
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
textureSampleLeveltests take hours on Windows in CI #9974.Current known issue(s):
CTS (Other)job is getting fairly long at ~30m.OtherCTS run is getting massively long, timing out at 6h.