[core] Promote unexpected varying types to log::error. - #9982
Merged
ErichDonGubler merged 1 commit intoAug 3, 2026
Merged
Conversation
When `wgpu_core` finds a binding with an unexpected type, log that with `error` severity, not `debug`. This was demoted to `debug` in be6898f, because, as the comment says: > every shader coming from `glslc` outputs an array of clip distances > and hits this path :( However, gfx-rs#8762 added a match case above this that handles clip distance arrays, so such output should no longer trigger any logging at all.
ErichDonGubler
approved these changes
Aug 3, 2026
ErichDonGubler
left a comment
ErichDonGubler
left a comment
Member
There was a problem hiding this comment.
Schweet, love seeing us being able to be more pedantic helpful.
ErichDonGubler
added
backend: gles
Member
|
question(non-blocking): This isn't super important to spend a lot of time on IMO, but I want to ask: Is there some signal I missed here for updating this? I'm wondering if I need to improve how I pay attention to things connected to validation like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
wgpu_corefinds a binding with an unexpected type, log that witherrorseverity, notdebug. This was demoted todebugin be6898f, because, as the comment says:However, #8762 added a match case above this that handles clip distance arrays, so such output should no longer trigger any logging at all.
cc: @ErichDonGubler