[core] Use minimum_binding_size terminology in validation. - #9988
Merged
ErichDonGubler merged 2 commits intoAug 3, 2026
Merged
Conversation
In `wgpu_core::validation`, rename `ResourceType::Buffer::size` to `minimum_binding_size`, for clarity. Adjust use sites accordingly.
jimblandy
changed the title
size to minimum_binding_size in validation.minimum_binding_size terminology in validation.
In `wgpu_core::validation::Interface::check_stage`, rename the `shader_binding_sizes` argument to `minimum_binding_sizes`. We already know from context that we're talking about a shader. This is not a table of actual binding sizes, it is a table of the minimum required binding sizes, given the module's resource interface.
jimblandy
force-pushed
the
core-rename-resourcetype-buffer-minimum-binding-size
branch
from
August 2, 2026 01:14
5200ff5 to
b631851
Compare
ErichDonGubler
approved these changes
Aug 3, 2026
ErichDonGubler
added
area: validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
wgpu_core::validation, renameResourceType::Buffer::sizetominimum_binding_size, for clarity. Adjust use sites accordingly.In
wgpu_core::validation::Interface::check_stage, rename theshader_binding_sizesargument tominimum_binding_sizes. We already know from context that we're talking about a shader. This is not a table of actual binding sizes, it is a table of the minimum required binding sizes, given the module's resource interface.This pull request makes no substantive changes to the code.