Skip to content

terminal: report DECECM as permanently reset#12660

Open
athaapa wants to merge 3 commits into
ghostty-org:mainfrom
athaapa:fix-dececm-decrqm-report
Open

terminal: report DECECM as permanently reset#12660
athaapa wants to merge 3 commits into
ghostty-org:mainfrom
athaapa:fix-dececm-decrqm-report

Conversation

@athaapa

@athaapa athaapa commented May 11, 2026

Copy link
Copy Markdown

Closes #12505

This PR allows Ghostty to respond to DECRQM queries for DECECM with the "permanently reset".

AI disclosure: I used Codex to help inspect the relevant code path and explain the issue, but I reviewed and made the code changes myself.

@athaapa athaapa requested a review from a team as a code owner May 11, 2026 23:21
@ghostty-bot ghostty-bot Bot added the vt Control sequence related label May 11, 2026

@pluiedev pluiedev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff itself looks good, but maybe we want to attach some context as to why we do this? (links, etc)

@athaapa

athaapa commented May 16, 2026

Copy link
Copy Markdown
Author

Yeah, that’s fair. If an application queries ?117, returning not recognized does not tell it which erase-color behavior Ghostty uses. Returning permanently reset tells it that Ghostty recognizes the mode but always uses the reset behavior. I updated the comment with that context and linked the VT520/VT525 Programmer Information.

@athaapa

athaapa commented May 26, 2026

Copy link
Copy Markdown
Author

Friendly ping. I addressed the review feedback and this has one approval now. Is there anything else you’d like changed before this can land?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vt Control sequence related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement response to DECRQM for DECECM as "permanently reset"

3 participants