[feat]: add ocserv-exporter (fix #4)#5
Merged
Conversation
gifi71
reviewed
Jul 27, 2025
…nasiev/ocserv-docker into feature/add_ocserv-exporter
gifi71
approved these changes
Jul 27, 2025
gifi71
left a comment
gifi71
left a comment
Owner
There was a problem hiding this comment.
Review summary:
- The PR adds an optional Prometheus metrics exporter (ocserv-exporter) integrated via s6 overlay for process supervision.
- Healthchecks have been improved to cover both the main ocserv service and the exporter.
- The Dockerfile was optimized.
- All checks have passed, and the changes are backward-compatible and well-structured.
Conclusion:
This PR is ready to merge. Great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about Add optional Prometheus metrics exporter for ocserv using occtl (#4) issue.