refactor: replace convert_to_full_spatial_network with file-local helper#131
Merged
Conversation
GiottoClass 0.6.0 removed convert_to_full_spatial_network(). The three viz_spatial_network.R consumers all needed the same operation: bidirectionalize canonical (from, to) edges into (source, target) form and compute rank_int (rank by distance, per source) for plotting k-neighbor distance distributions and Delaunay network statistics. Adds .full_with_rank() at the top of the file (3 sites → small local helper rather than 3 inline copies). rank_int is computed JIT because any topology mutation (induced_subgraph, external filtering) would invalidate a stored value — same semantics as the old helper, which also recomputed every call. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GiottoClass 0.6.0 removed convert_to_full_spatial_network(). The three viz_spatial_network.R consumers all needed the same operation: bidirectionalize canonical (from, to) edges into (source, target) form and compute rank_int (rank by distance, per source) for plotting k-neighbor distance distributions and Delaunay network statistics.
Adds .full_with_rank() at the top of the file (3 sites → small local helper rather than 3 inline copies). rank_int is computed JIT because any topology mutation (induced_subgraph, external filtering) would invalidate a stored value — same semantics as the old helper, which also recomputed every call.