Draft
Conversation
Owner
|
Thank you for this. I don’t recall but I had issues with cgroups in the past on my Fedora machine. It’s probably bad settings on my part. These settings seem to work just fine on Fedora and on Ubuntu in the CI. Are there any trade-offs to this change? Can/Should the TaskPlugin do both task/cgroup,task/affinity? Would this be a breaking change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qq: Is there any reason why cgroup is not enabled by default? I noticed that memory limit didn't work then I realized cgroup is not on.
I think this is the only realistic setup we'll have, and if there's no reason to stick with proctrack/linuxproc, let's move to cgroup.
Note: I have no chance to test this on cgroup v1 systems, will mark it ready only after I can test.