Skip to content

Expose routines for reading and creating .png files #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zur003 wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Open

Expose routines for reading and creating .png files #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43db629
Support routines for reading and creating .png files
zur003 Jul 4, 2026
8b7cb71
Small changes to address review comments.
zur003 Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Libs/cairo-1.0/Internal/ImageSurface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ public class ImageSurface
[DllImport(CairoImportResolver.Library, EntryPoint = "cairo_image_surface_create_for_data")]
public static extern SurfaceOwnedHandle CreateForData(IntPtr data, Cairo.Format format, int width, int height, int stride);

[DllImport(CairoImportResolver.Library, EntryPoint = "cairo_image_surface_create_from_png")]
public static extern SurfaceOwnedHandle CreateFromPng(GLib.Internal.NonNullableUtf8StringOwnedHandle filename);

[DllImport(CairoImportResolver.Library, EntryPoint = "cairo_image_surface_get_data")]
public static extern IntPtr GetData(SurfaceHandle handle);

Expand Down
3 changes: 3 additions & 0 deletions src/Libs/cairo-1.0/Internal/Surface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,7 @@ public partial class Surface

[DllImport(CairoImportResolver.Library, EntryPoint = "cairo_surface_status")]
public static extern Status Status(SurfaceHandle handle);

[DllImport(CairoImportResolver.Library, EntryPoint = "cairo_surface_write_to_png")]
Comment thread
badcel marked this conversation as resolved.
public static extern Status WriteToPng(SurfaceHandle handle, GLib.Internal.NonNullableUtf8StringOwnedHandle filename);
}
6 changes: 6 additions & 0 deletions src/Libs/cairo-1.0/Public/ImageSurface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ public ImageSurface(GLib.Bytes data, Format format, int width, int height, int s
SetUserData(data);
}

public ImageSurface(string filename) :

@badcel badcel Jul 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like the constructor here as it does not make clear that it is valid for png only.

We should at least rename the parameter to filenamePng or similar. But then there would be no way to create other image surfaces from a file name.

On the other hand I like that it's aligned with the rest of the API.

There is still issue: #1506

So to come to a conclusion: Let's start with a regular constructor in this PR and other considerations come later.

What do you think?

base(Internal.ImageSurface.CreateFromPng(GLib.Internal.NonNullableUtf8StringOwnedHandle.Create(filename)))
{
Handle.AddMemoryPressure(GetSizeInBytes());
}

private void SetUserData(GLib.Bytes data)
{
var userDataHandler = new Internal.UserDataHandler(data.Handle);
Expand Down
6 changes: 6 additions & 0 deletions src/Libs/cairo-1.0/Public/Surface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,10 @@ public void MarkDirty(int x, int y, int width, int height)
? null
: new Device(deviceHandle.OwnedCopy());
}

public Status WriteToPng(string filename)
Comment thread
badcel marked this conversation as resolved.
{
using var filenameNative = GLib.Internal.NonNullableUtf8StringOwnedHandle.Create(filename);
return Internal.Surface.WriteToPng(Handle, filenameNative);
}
}
Loading