Skip to content

Possible naming improvements via codegen changes #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SteveSandersonMS wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Possible naming improvements via codegen changes #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
216407b
Rebase on main and regenerate all SDK output
SteveSandersonMS Apr 13, 2026
33ce544
Make codegen able to handle void-result RPC methods
SteveSandersonMS Apr 13, 2026
0efd328
In Go, buy some more forward-compat by ensuring RPC methods never ret…
SteveSandersonMS Apr 13, 2026
6922592
Regenerate now "session.mode.set" returns void
SteveSandersonMS Apr 13, 2026
222851e
Fully support void-returning RPC methods and regenerate
SteveSandersonMS Apr 13, 2026
41c3f91
Many fixes
SteveSandersonMS Apr 13, 2026
ecafa7a
Regen
SteveSandersonMS Apr 13, 2026
b5ef3ca
Renames
SteveSandersonMS Apr 13, 2026
b5a019c
Update rpc.test.ts
SteveSandersonMS Apr 13, 2026
a84f05c
Regen again
SteveSandersonMS Apr 13, 2026
797627f
Yet again
SteveSandersonMS Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/features/image-input.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ public static class ImageInputExample
await session.SendAsync(new MessageOptions
{
Prompt = "Describe what you see in this image",
Attachments = new List<UserMessageDataAttachmentsItem>
Attachments = new List<UserMessageAttachment>
{
new UserMessageDataAttachmentsItemFile
new UserMessageAttachmentFile
{
Path = "/absolute/path/to/screenshot.png",
DisplayName = "screenshot.png",
Expand All @@ -206,9 +206,9 @@ await using var session = await client.CreateSessionAsync(new SessionConfig
await session.SendAsync(new MessageOptions
{
Prompt = "Describe what you see in this image",
Attachments = new List<UserMessageDataAttachmentsItem>
Attachments = new List<UserMessageAttachment>
{
new UserMessageDataAttachmentsItemFile
new UserMessageAttachmentFile
{
Path = "/absolute/path/to/screenshot.png",
DisplayName = "screenshot.png",
Expand Down Expand Up @@ -396,9 +396,9 @@ public static class BlobAttachmentExample
await session.SendAsync(new MessageOptions
{
Prompt = "Describe what you see in this image",
Attachments = new List<UserMessageDataAttachmentsItem>
Attachments = new List<UserMessageAttachment>
{
new UserMessageDataAttachmentsItemBlob
new UserMessageAttachmentBlob
{
Data = base64ImageData,
MimeType = "image/png",
Expand All @@ -415,9 +415,9 @@ public static class BlobAttachmentExample
await session.SendAsync(new MessageOptions
{
Prompt = "Describe what you see in this image",
Attachments = new List<UserMessageDataAttachmentsItem>
Attachments = new List<UserMessageAttachment>
{
new UserMessageDataAttachmentsItemBlob
new UserMessageAttachmentBlob
{
Data = base64ImageData,
MimeType = "image/png",
Expand Down
5 changes: 5 additions & 0 deletions dotnet/src/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,11 @@ internal static async Task<T> InvokeRpcAsync<T>(JsonRpc rpc, string method, obje
return await InvokeRpcAsync<T>(rpc, method, args, null, cancellationToken);
}

internal static async Task InvokeRpcAsync(JsonRpc rpc, string method, object?[]? args, CancellationToken cancellationToken)
{
await InvokeRpcAsync<object>(rpc, method, args, null, cancellationToken);
}

internal static async Task<T> InvokeRpcAsync<T>(JsonRpc rpc, string method, object?[]? args, StringBuilder? stderrBuffer, CancellationToken cancellationToken)
{
try
Expand Down
Loading
Loading