Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Go SDK’s internal jsonrpc2 stdio transport by introducing dedicated Content-Length framing, simplifying message decoding, and standardizing error handling for JSON-RPC 2.0 interactions with the Copilot CLI.
Changes:
- Introduces
headerReader/headerWriterfor Content-Length framed IO and uses them inClient(plus channel-based write serialization). - Replaces “try request then response” decoding with a single
decodeMessagethat validates thejsonrpcversion and discriminates request vs response. - Updates JSON-RPC error handling (standard error sentinels;
Error.Databecomesjson.RawMessage; removes unusedNotify).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| go/internal/jsonrpc2/jsonrpc2.go | Switches to framed IO + unified decode path, updates error model, and removes Notify/write-mutex usage. |
| go/internal/jsonrpc2/frame.go | Adds Content-Length header framing reader/writer implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens the internal jsonrpc2 package: