Skip to content

fix: capture full session state — replace blanket ~/.copilot mount, add --session-state-dir #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 6 commits into from
Apr 2, 2026
Merged

fix: capture full session state — replace blanket ~/.copilot mount, add --session-state-dir #1593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db0d0a7
fix: replace blanket ~/.copilot chroot mount with targeted session-st…
lpcox Apr 2, 2026
897cbec
feat: add --session-state-dir flag for timeout-safe session export
lpcox Apr 2, 2026
e296489
fix: pre-create .copilot in empty home volume for package extraction
lpcox Apr 2, 2026
7d72846
fix: keep ~/.copilot host mount with session-state/logs overlays
lpcox Apr 2, 2026
a134e5c
fix: chown session-state and agent-logs dirs to host user
lpcox Apr 2, 2026
84bd39a
test: add cleanup tests for sessionStateDir branches
lpcox Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/docker-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,11 @@ describe('docker-manager', () => {
// CLI state directories
expect(volumes).toContain(`${homeDir}/.claude:/host${homeDir}/.claude:rw`);
expect(volumes).toContain(`${homeDir}/.anthropic:/host${homeDir}/.anthropic:rw`);
expect(volumes).toContain(`${homeDir}/.copilot:/host${homeDir}/.copilot:rw`);
// ~/.copilot is NOT blanket-mounted (security: may contain config/auth state)
// Instead, session-state and logs are mounted from AWF workDir at chroot paths
expect(volumes).not.toContain(`${homeDir}/.copilot:/host${homeDir}/.copilot:rw`);
expect(volumes).toContain(`/tmp/awf-test/agent-session-state:/host${homeDir}/.copilot/session-state:rw`);
expect(volumes).toContain(`/tmp/awf-test/agent-logs:/host${homeDir}/.copilot/logs:rw`);
});

it('should add SYS_CHROOT and SYS_ADMIN capabilities but NOT NET_ADMIN', () => {
Expand Down
13 changes: 9 additions & 4 deletions src/docker-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,9 +832,14 @@ export function generateDockerCompose(
// - One-shot token LD_PRELOAD library: /host/tmp/awf-lib/one-shot-token.so
agentVolumes.push('/tmp:/host/tmp:rw');

// Mount ~/.copilot for GitHub Copilot CLI (package extraction, config, logs)
// This is safe as ~/.copilot contains only Copilot CLI state, not credentials
agentVolumes.push(`${effectiveHome}/.copilot:/host${effectiveHome}/.copilot:rw`);
// Mount AWF workDir session-state and logs at chroot paths so events.jsonl and
// logs are captured in the AWF workDir (not written to the host's ~/.copilot).
// We intentionally do NOT mount the entire ~/.copilot directory, because it may
// contain configuration or cached auth state that should not be exposed to the
// sandboxed agent. The empty home volume (above) provides a writable ~/.copilot
// for Copilot CLI to create any other files it needs.
agentVolumes.push(`${config.workDir}/agent-session-state:/host${effectiveHome}/.copilot/session-state:rw`);
agentVolumes.push(`${config.workDir}/agent-logs:/host${effectiveHome}/.copilot/logs:rw`);

// Mount ~/.cache, ~/.config, ~/.local for CLI tool state management (Claude Code, etc.)
// These directories are safe to mount as they contain application state, not credentials
Expand Down Expand Up @@ -1017,7 +1022,7 @@ export function generateDockerCompose(
//
// Instead of mounting the entire $HOME directory (which contained credentials), we now:
// 1. Mount ONLY the workspace directory ($GITHUB_WORKSPACE or cwd)
// 2. Mount ~/.copilot/logs separately for Copilot CLI logging
// 2. Mount ~/.copilot/logs and ~/.copilot/session-state from AWF workDir (not host)
// 3. Hide credential files by mounting /dev/null over them (defense-in-depth)
// 4. Allow users to add specific mounts via --mount flag
//
Expand Down
Loading