chore: upgrade go-sdk to v1.5.0 and address go-fan review items by Copilot · Pull Request #3610 · github/gh-aw-mcpg

Copilot · 2026-04-11T21:03:05Z

The project was on go-sdk v1.4.1 while v1.5.0 was available, and two fragility concerns were identified: session expiry detection via string matching and SSE deprecation warnings bypassing the structured logger.

Changes

go.mod/go.sum — upgrade github.com/modelcontextprotocol/go-sdk v1.4.1 → v1.5.0

internal/mcp/http_transport.go — replace string-matching session error detection with the typed sentinel introduced in v1.5.0, retaining string-match as fallback for non-SDK (plain JSON-RPC) transports:

// Before (fragile):
return strings.Contains(strings.ToLower(err.Error()), "session not found")

// After (robust, with fallback):
if errors.Is(err, sdk.ErrSessionMissing) { return true }
return strings.Contains(strings.ToLower(err.Error()), "session not found")

internal/mcp/connection.go — route SSE deprecation log.Printf calls through logger.LogWarn so they appear in mcp-gateway.log instead of bypassing the structured logging pipeline
internal/server/tool_registry.go — update registerToolWithoutValidation comment to accurately reflect v1.5.0 Server.AddTool behaviour: now enforces type: "object" on the input schema but still does not validate argument values at call time; notes verification against v1.5.0 source

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

example.com
- Triggering command: /tmp/go-build347415617/b510/launcher.test /tmp/go-build347415617/b510/launcher.test -test.testlogfile=/tmp/go-build347415617/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/net -trimpath de/node/bin/as -p io -lang=go1.25 o_main.o -I uf@v1.36.11/refl-errorsas uf@v1.36.11/refl-ifaceassert x_amd64/vet --gdwarf-5 --64 -o x_amd64/vet (dns block)
- Triggering command: /tmp/go-build2356109318/b510/launcher.test /tmp/go-build2356109318/b510/launcher.test -test.testlogfile=/tmp/go-build2356109318/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true eFSy5PFyu cfg 64/pkg/tool/linux_amd64/vet --gdwarf-5 --64 -o 64/pkg/tool/linu--others pkg/�� om/davecgh/go-spew@v1.1.1/spew/bypass.go cfg 64/pkg/tool/linux_amd64/vet -plugin-opt=-pasbash g/grpc/internal/--norc -plugin-opt=-pas--noprofile 64/pkg/tool/linux_amd64/vet (dns block)
- Triggering command: /tmp/go-build2885812085/b514/launcher.test /tmp/go-build2885812085/b514/launcher.test -test.testlogfile=/tmp/go-build2885812085/b514/testlog.txt -test.paniconexit0 -test.timeout=10m0s -ato�� -bool -buildtags iginal -errorsas -ifaceassert -nilfunc iginal -ato�� /launcher/connection_pool.go /launcher/health_monitor.go x_amd64/vet -errorsas -ifaceassert -nilfunc x_amd64/vet (dns block)
invalid-host-that-does-not-exist-12345.com
- Triggering command: /tmp/go-build347415617/b492/config.test /tmp/go-build347415617/b492/config.test -test.testlogfile=/tmp/go-build347415617/b492/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true o /home/REDACTED/go/pkg/mod/github.c--64 x_amd64/compile /home/REDACTED/go//opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet fips140/ecdsa /home/REDACTED/go/-unreachable=false x_amd64/compile ual_�� azero@v1.11.0/internal/wasmdebug-p azero@v1.11.0/internal/wasmdebuggolang.org/x/net/http2 x_amd64/asm -p crypto/internal/-atomic -lang=go1.25 x_amd64/asm (dns block)
- Triggering command: /tmp/go-build2885812085/b496/config.test /tmp/go-build2885812085/b496/config.test -test.testlogfile=/tmp/go-build2885812085/b496/testlog.txt -test.paniconexit0 -test.timeout=10m0s -uns�� -unreachable=false /tmp/go-build347415617/b075/vet.cfg ash g_.a gmYLA_3tW .13/x64/as /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu--others -ato�� -bool -buildtags 86_64/git -errorsas -ifaceassert -nilfunc iginal (dns block)
nonexistent.local
- Triggering command: /tmp/go-build347415617/b510/launcher.test /tmp/go-build347415617/b510/launcher.test -test.testlogfile=/tmp/go-build347415617/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/net -trimpath de/node/bin/as -p io -lang=go1.25 o_main.o -I uf@v1.36.11/refl-errorsas uf@v1.36.11/refl-ifaceassert x_amd64/vet --gdwarf-5 --64 -o x_amd64/vet (dns block)
- Triggering command: /tmp/go-build2356109318/b510/launcher.test /tmp/go-build2356109318/b510/launcher.test -test.testlogfile=/tmp/go-build2356109318/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true eFSy5PFyu cfg 64/pkg/tool/linux_amd64/vet --gdwarf-5 --64 -o 64/pkg/tool/linu--others pkg/�� om/davecgh/go-spew@v1.1.1/spew/bypass.go cfg 64/pkg/tool/linux_amd64/vet -plugin-opt=-pasbash g/grpc/internal/--norc -plugin-opt=-pas--noprofile 64/pkg/tool/linux_amd64/vet (dns block)
- Triggering command: /tmp/go-build2885812085/b514/launcher.test /tmp/go-build2885812085/b514/launcher.test -test.testlogfile=/tmp/go-build2885812085/b514/testlog.txt -test.paniconexit0 -test.timeout=10m0s -ato�� -bool -buildtags iginal -errorsas -ifaceassert -nilfunc iginal -ato�� /launcher/connection_pool.go /launcher/health_monitor.go x_amd64/vet -errorsas -ifaceassert -nilfunc x_amd64/vet (dns block)
slow.example.com
- Triggering command: /tmp/go-build347415617/b510/launcher.test /tmp/go-build347415617/b510/launcher.test -test.testlogfile=/tmp/go-build347415617/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/net -trimpath de/node/bin/as -p io -lang=go1.25 o_main.o -I uf@v1.36.11/refl-errorsas uf@v1.36.11/refl-ifaceassert x_amd64/vet --gdwarf-5 --64 -o x_amd64/vet (dns block)
- Triggering command: /tmp/go-build2356109318/b510/launcher.test /tmp/go-build2356109318/b510/launcher.test -test.testlogfile=/tmp/go-build2356109318/b510/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true eFSy5PFyu cfg 64/pkg/tool/linux_amd64/vet --gdwarf-5 --64 -o 64/pkg/tool/linu--others pkg/�� om/davecgh/go-spew@v1.1.1/spew/bypass.go cfg 64/pkg/tool/linux_amd64/vet -plugin-opt=-pasbash g/grpc/internal/--norc -plugin-opt=-pas--noprofile 64/pkg/tool/linux_amd64/vet (dns block)
- Triggering command: /tmp/go-build2885812085/b514/launcher.test /tmp/go-build2885812085/b514/launcher.test -test.testlogfile=/tmp/go-build2885812085/b514/testlog.txt -test.paniconexit0 -test.timeout=10m0s -ato�� -bool -buildtags iginal -errorsas -ifaceassert -nilfunc iginal -ato�� /launcher/connection_pool.go /launcher/health_monitor.go x_amd64/vet -errorsas -ifaceassert -nilfunc x_amd64/vet (dns block)
this-host-does-not-exist-12345.com
- Triggering command: /tmp/go-build347415617/b519/mcp.test /tmp/go-build347415617/b519/mcp.test -test.testlogfile=/tmp/go-build347415617/b519/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 1.80.0/internal/channelz/channel.go 1.80.0/internal/channelz/channelmap.go x_amd64/vet 305_amd64.s --64 -o x_amd64/vet 0880�� m/grpc-gateway/v2@v2.28.0/runtim-errorsas m/grpc-gateway/v2@v2.28.0/runtim-ifaceassert x_amd64/vet --gdwarf-5 --64 -o x_amd64/vet (dns block)
- Triggering command: /tmp/go-build2356109318/b519/mcp.test /tmp/go-build2356109318/b519/mcp.test -test.testlogfile=/tmp/go-build2356109318/b519/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true olang.org/grpc@v-p cfg 64/pkg/tool/linu-lang=go1.25 0880581/b288/ --64 (dns block)
- Triggering command: /tmp/go-build2885812085/b523/mcp.test /tmp/go-build2885812085/b523/mcp.test -test.testlogfile=/tmp/go-build2885812085/b523/testlog.txt -test.paniconexit0 -test.timeout=10m0s -ato�� -bool -buildtags x_amd64/vet -errorsas -ifaceassert -nilfunc x_amd64/vet /usr�� --version -tests x_amd64/vet balancer/weight/grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/09a95415-798b-406d-9dbf-101e2e388180 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

…, route SSE warnings to structured logger, update tool_registry comment Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/09a95415-798b-406d-9dbf-101e2e388180 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot

Pull request overview

Upgrades the MCP Go SDK dependency to v1.5.0 and hardens/aligns gateway behavior with the newer SDK by using typed session-missing detection and ensuring SSE deprecation warnings flow through the gateway’s logging pipeline.

Changes:

Bump github.com/modelcontextprotocol/go-sdk to v1.5.0 (and refresh transitive sums).
Use errors.Is(err, sdk.ErrSessionMissing) for session-missing detection with a string-match fallback.
Route SSE deprecation warnings through logger.LogWarn and update the tool-registration comment to reflect v1.5.0 Server.AddTool behavior.

Show a summary per file

File	Description
go.mod	Upgrades MCP Go SDK requirement to v1.5.0.
go.sum	Updates checksums for the SDK upgrade and related transitive deps.
internal/mcp/http_transport.go	Switches session-missing detection to a typed sentinel with fallback string matching.
internal/mcp/connection.go	Sends SSE deprecation warnings through structured logging instead of `log.Printf`.
internal/server/tool_registry.go	Updates documentation comment about `Server.AddTool` vs `sdk.AddTool` behavior in v1.5.0.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 4/5 changed files
Comments generated: 2

Copilot · 2026-04-11T21:20:00Z

internal/mcp/http_transport.go

 func isSessionNotFoundError(err error) bool {
 	if err == nil {
 		return false
 	}
+	if errors.Is(err, sdk.ErrSessionMissing) {
+		return true
+	}


The new errors.Is(err, sdk.ErrSessionMissing) branch isn’t covered by the existing TestIsSessionNotFoundError cases (which only exercise string matching). Add a test that passes sdk.ErrSessionMissing (and ideally a wrapped %w form) so this typed-sentinel detection is validated and won’t silently regress on future SDK upgrades.

Copilot · 2026-04-11T21:20:01Z

internal/mcp/connection.go

-		log.Printf("Configured HTTP MCP server with SSE transport: %s", url)
+		logger.LogWarn("backend", "⚠️  WARNING: MCP over SSE (2024-11-05 spec) has been DEPRECATED")
+		logger.LogWarn("backend", "⚠️  The server at %s is using the deprecated SSE transport", url)
+		logger.LogWarn("backend", "⚠️  Please migrate to streamable HTTP transport (2025-03-26 spec)")


logConn.Printf is DEBUG-gated (and logs at debug level to the file logger), so this message will no longer be visible by default (unlike the previous log.Printf) and may not land in mcp-gateway.log at WARN/INFO. If this line is intended as part of the SSE deprecation/operator visibility, route it through the structured logger too (e.g., logger.LogWarn/LogInfo) for consistency with the other deprecation messages.

Suggested change

logger.LogWarn("backend", "⚠️ Please migrate to streamable HTTP transport (2025-03-26 spec)")

logger.LogWarn("backend", "⚠️ Please migrate to streamable HTTP transport (2025-03-26 spec)")

logger.LogWarn("backend", "Configured HTTP MCP server with SSE transport: %s", url)

…E warning - Add test cases for sdk.ErrSessionMissing sentinel and wrapped form to TestIsSessionNotFoundError, ensuring typed-sentinel detection won't silently regress on future SDK upgrades. - Replace debug-gated logConn.Printf with logger.LogWarn for the SSE transport configuration message, ensuring operator visibility in mcp-gateway.log at WARN level. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Initial plan

05a8efe

Copilot AI assigned Copilot and lpcox Apr 11, 2026

Copilot started work on behalf of lpcox April 11, 2026 21:03 View session

Copilot AI linked an issue Apr 11, 2026 that may be closed by this pull request

[go-fan] Go Module Review: modelcontextprotocol/go-sdk #3423

Closed

4 tasks

Copilot AI and others added 2 commits April 11, 2026 21:06

chore: upgrade go-sdk to v1.5.0

6b3df9a

Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/09a95415-798b-406d-9dbf-101e2e388180 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Review go-sdk for version upgrade and structural improvements~~ chore: upgrade go-sdk to v1.5.0 and address go-fan review items Apr 11, 2026

Copilot AI requested a review from lpcox April 11, 2026 21:10

Copilot finished work on behalf of lpcox April 11, 2026 21:10

lpcox marked this pull request as ready for review April 11, 2026 21:16

Copilot AI review requested due to automatic review settings April 11, 2026 21:16

Copilot started reviewing on behalf of lpcox April 11, 2026 21:17 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

lpcox merged commit a82e67c into main Apr 11, 2026
13 checks passed

lpcox deleted the copilot/go-fan-review-go-sdk branch April 11, 2026 21:30

This was referenced Apr 11, 2026

Smoke Test: Copilot - 24292025441 #3615

Closed

Smoke Test: Copilot - 24292065153 #3617

Closed

Smoke Test: Copilot - 24295513009 #3625

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade go-sdk to v1.5.0 and address go-fan review items#3610

chore: upgrade go-sdk to v1.5.0 and address go-fan review items#3610
lpcox merged 4 commits intomainfrom
copilot/go-fan-review-go-sdk

Copilot AI commented Apr 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 11, 2026

Uh oh!

Copilot AI Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	logger.LogWarn("backend", "⚠️ Please migrate to streamable HTTP transport (2025-03-26 spec)")
	logger.LogWarn("backend", "⚠️ Please migrate to streamable HTTP transport (2025-03-26 spec)")
	logger.LogWarn("backend", "Configured HTTP MCP server with SSE transport: %s", url)

Conversation

Copilot AI commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 11, 2026 •

edited

Loading