fix: update trial mode tests to match generateYAML's 4-value return signature#25138
Merged
fix: update trial mode tests to match generateYAML's 4-value return signature#25138
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/5ec12fd1-b107-48c1-ae18-114fdf87323f Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 7, 2026 18:06
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates integration test call sites to match generateYAML’s updated 4-value return signature, fixing CI build failures caused by incorrect destructuring in trial-mode tests.
Changes:
- Updated
generateYAMLcall sites intrial_mode_test.go(3 occurrences) to destructure(string, []string, []string, error). - Updated
generateYAMLcall sites intrial_issue_mode_test.go(2 occurrences) to destructure(string, []string, []string, error).
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/trial_mode_test.go | Adjusts generateYAML destructuring to include the two newly returned slices (ignored via _). |
| pkg/workflow/trial_issue_mode_test.go | Same destructuring fix for issue-trigger trial mode integration tests. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateYAMLwas updated to return(string, []string, []string, error)but 5 call sites across the trial mode test files still destructured only 2 values, causing a build failure in CI integration tests.Changes
trial_mode_test.go(3 sites) andtrial_issue_mode_test.go(2 sites): updatedgenerateYAMLcalls fromlockContent, err :=tolockContent, _, _, err :=