Skip to content

Restore digest pinning for AWF 0.27.0 firewall sidecar images #38595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jun 11, 2026
Merged

Restore digest pinning for AWF 0.27.0 firewall sidecar images #38595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c5dc1
Initial plan
Copilot Jun 11, 2026
f8dabac
Pin AWF 0.27.0 firewall images
Copilot Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/aw/actions-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
"digest": "sha256:0f54fa48dd1a03ef6d171574eecf9a9edbf0406cea011a534cd12ed1fcb46715",
"pinned_image": "ghcr.io/github/gh-aw-firewall/agent:0.25.67@sha256:0f54fa48dd1a03ef6d171574eecf9a9edbf0406cea011a534cd12ed1fcb46715"
},
"ghcr.io/github/gh-aw-firewall/agent:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/agent:0.27.0",
"digest": "sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248",
"pinned_image": "ghcr.io/github/gh-aw-firewall/agent:0.27.0@sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248"
},
"ghcr.io/github/gh-aw-firewall/agent:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/agent:0.27.1",
"digest": "sha256:55149fa2daf8fa8afa2803f2ac1a3534591a7c96f173ee2aec9545fbe67305df",
Expand Down Expand Up @@ -292,6 +297,11 @@
"digest": "sha256:d3f51df1869bda0e1f71ae31a81450641c6ae67404e0769469aae34c2738aeb5",
"pinned_image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.25.67@sha256:d3f51df1869bda0e1f71ae31a81450641c6ae67404e0769469aae34c2738aeb5"
},
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0",
"digest": "sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb",
"pinned_image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0@sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb"
},
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.1",
"digest": "sha256:2802437f05830336ea3ae8639f628776608d14d95b5b3cf30f161eb505e29752",
Expand Down Expand Up @@ -327,6 +337,11 @@
"digest": "sha256:97387002ec54c8ab9f255d5aaf3d435071642e058f528c8268ca0e80b201609a",
"pinned_image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.67@sha256:97387002ec54c8ab9f255d5aaf3d435071642e058f528c8268ca0e80b201609a"
},
"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0",
"digest": "sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d",
"pinned_image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0@sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d"
},
"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.1",
"digest": "sha256:2e6dc98321dbf82840f83ec0ef8b198506149255a15d3a7854d59c0d34063e27",
Expand Down Expand Up @@ -372,6 +387,11 @@
"digest": "sha256:9a05085db054f41bd67c772bcfc25cabc15bc33ee993b051a31e30669dd2031f",
"pinned_image": "ghcr.io/github/gh-aw-firewall/squid:0.25.67@sha256:9a05085db054f41bd67c772bcfc25cabc15bc33ee993b051a31e30669dd2031f"
},
"ghcr.io/github/gh-aw-firewall/squid:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/squid:0.27.0",
"digest": "sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6",
"pinned_image": "ghcr.io/github/gh-aw-firewall/squid:0.27.0@sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6"
},
"ghcr.io/github/gh-aw-firewall/squid:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/squid:0.27.1",
"digest": "sha256:1f3df3207dc9faa9080088115ca50a5ab0d7a692c61dffa8c8898d0b7b750413",
Expand Down
20 changes: 20 additions & 0 deletions pkg/actionpins/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
"digest": "sha256:0f54fa48dd1a03ef6d171574eecf9a9edbf0406cea011a534cd12ed1fcb46715",
"pinned_image": "ghcr.io/github/gh-aw-firewall/agent:0.25.67@sha256:0f54fa48dd1a03ef6d171574eecf9a9edbf0406cea011a534cd12ed1fcb46715"
},
"ghcr.io/github/gh-aw-firewall/agent:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/agent:0.27.0",
"digest": "sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248",
"pinned_image": "ghcr.io/github/gh-aw-firewall/agent:0.27.0@sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248"
},
"ghcr.io/github/gh-aw-firewall/agent:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/agent:0.27.1",
"digest": "sha256:55149fa2daf8fa8afa2803f2ac1a3534591a7c96f173ee2aec9545fbe67305df",
Expand Down Expand Up @@ -292,6 +297,11 @@
"digest": "sha256:d3f51df1869bda0e1f71ae31a81450641c6ae67404e0769469aae34c2738aeb5",
"pinned_image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.25.67@sha256:d3f51df1869bda0e1f71ae31a81450641c6ae67404e0769469aae34c2738aeb5"
},
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0",
"digest": "sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb",
"pinned_image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0@sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb"
},
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.1",
"digest": "sha256:2802437f05830336ea3ae8639f628776608d14d95b5b3cf30f161eb505e29752",
Expand Down Expand Up @@ -327,6 +337,11 @@
"digest": "sha256:97387002ec54c8ab9f255d5aaf3d435071642e058f528c8268ca0e80b201609a",
"pinned_image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.67@sha256:97387002ec54c8ab9f255d5aaf3d435071642e058f528c8268ca0e80b201609a"
},
"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0",
"digest": "sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d",
"pinned_image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0@sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d"
},
"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.1",
"digest": "sha256:2e6dc98321dbf82840f83ec0ef8b198506149255a15d3a7854d59c0d34063e27",
Expand Down Expand Up @@ -372,6 +387,11 @@
"digest": "sha256:9a05085db054f41bd67c772bcfc25cabc15bc33ee993b051a31e30669dd2031f",
"pinned_image": "ghcr.io/github/gh-aw-firewall/squid:0.25.67@sha256:9a05085db054f41bd67c772bcfc25cabc15bc33ee993b051a31e30669dd2031f"
},
"ghcr.io/github/gh-aw-firewall/squid:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/squid:0.27.0",
"digest": "sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6",
"pinned_image": "ghcr.io/github/gh-aw-firewall/squid:0.27.0@sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6"
},
"ghcr.io/github/gh-aw-firewall/squid:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/squid:0.27.1",
"digest": "sha256:1f3df3207dc9faa9080088115ca50a5ab0d7a692c61dffa8c8898d0b7b750413",
Expand Down
20 changes: 20 additions & 0 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
"digest": "sha256:0f54fa48dd1a03ef6d171574eecf9a9edbf0406cea011a534cd12ed1fcb46715",
"pinned_image": "ghcr.io/github/gh-aw-firewall/agent:0.25.67@sha256:0f54fa48dd1a03ef6d171574eecf9a9edbf0406cea011a534cd12ed1fcb46715"
},
"ghcr.io/github/gh-aw-firewall/agent:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/agent:0.27.0",
"digest": "sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248",
"pinned_image": "ghcr.io/github/gh-aw-firewall/agent:0.27.0@sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248"
},
"ghcr.io/github/gh-aw-firewall/agent:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/agent:0.27.1",
"digest": "sha256:55149fa2daf8fa8afa2803f2ac1a3534591a7c96f173ee2aec9545fbe67305df",
Expand Down Expand Up @@ -292,6 +297,11 @@
"digest": "sha256:d3f51df1869bda0e1f71ae31a81450641c6ae67404e0769469aae34c2738aeb5",
"pinned_image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.25.67@sha256:d3f51df1869bda0e1f71ae31a81450641c6ae67404e0769469aae34c2738aeb5"
},
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0",
"digest": "sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb",
"pinned_image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0@sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb"
},
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/api-proxy:0.27.1",
"digest": "sha256:2802437f05830336ea3ae8639f628776608d14d95b5b3cf30f161eb505e29752",
Expand Down Expand Up @@ -327,6 +337,11 @@
"digest": "sha256:97387002ec54c8ab9f255d5aaf3d435071642e058f528c8268ca0e80b201609a",
"pinned_image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.25.67@sha256:97387002ec54c8ab9f255d5aaf3d435071642e058f528c8268ca0e80b201609a"
},
"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0",
"digest": "sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d",
"pinned_image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.0@sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d"
},
"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.1",
"digest": "sha256:2e6dc98321dbf82840f83ec0ef8b198506149255a15d3a7854d59c0d34063e27",
Expand Down Expand Up @@ -372,6 +387,11 @@
"digest": "sha256:9a05085db054f41bd67c772bcfc25cabc15bc33ee993b051a31e30669dd2031f",
"pinned_image": "ghcr.io/github/gh-aw-firewall/squid:0.25.67@sha256:9a05085db054f41bd67c772bcfc25cabc15bc33ee993b051a31e30669dd2031f"
},
"ghcr.io/github/gh-aw-firewall/squid:0.27.0": {
"image": "ghcr.io/github/gh-aw-firewall/squid:0.27.0",
"digest": "sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6",
"pinned_image": "ghcr.io/github/gh-aw-firewall/squid:0.27.0@sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6"
},
"ghcr.io/github/gh-aw-firewall/squid:0.27.1": {
"image": "ghcr.io/github/gh-aw-firewall/squid:0.27.1",
"digest": "sha256:1f3df3207dc9faa9080088115ca50a5ab0d7a692c61dffa8c8898d0b7b750413",
Expand Down
82 changes: 82 additions & 0 deletions pkg/workflow/docker_firewall_pin_compile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
//go:build !integration

package workflow

import (
"os"
"path/filepath"
"strings"
"testing"

"github.com/github/gh-aw/pkg/stringutil"
"github.com/github/gh-aw/pkg/testutil"
)

func TestCompileWorkflow_FirewallImagesPinnedForAWF0270(t *testing.T) {
frontmatter := `---
on: workflow_dispatch
engine: claude
sandbox:
agent:
id: awf
version: v0.27.0
network:
allowed:
- defaults
tools:
web-fetch:
---

# Test
Test workflow.`

tmpDir := testutil.TempDir(t, "docker-firewall-pins-test")
testFile := filepath.Join(tmpDir, "test-workflow.md")
if err := os.WriteFile(testFile, []byte(frontmatter), 0644); err != nil {
t.Fatal(err)
}

compiler := NewCompiler()
if err := compiler.CompileWorkflow(testFile); err != nil {
t.Fatalf("Failed to compile workflow: %v", err)
}

lockFile := stringutil.MarkdownToLockFile(testFile)
yaml, err := os.ReadFile(lockFile)
if err != nil {
t.Fatalf("Failed to read lock file: %v", err)
}

yamlStr := string(yaml)

expectedPins := map[string]string{
"ghcr.io/github/gh-aw-firewall/agent:0.27.0": "sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248",
"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.0": "sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb",
"ghcr.io/github/gh-aw-firewall/squid:0.27.0": "sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6",
}

for image, digest := range expectedPins {
pinnedImage := image + "@" + digest
if !strings.Contains(yamlStr, `"image":"`+image+`","digest":"`+digest+`","pinned_image":"`+pinnedImage+`"`) {
t.Errorf("Expected manifest header to include pinned metadata for %s", image)
}
if !strings.Contains(yamlStr, "# - "+pinnedImage) {
t.Errorf("Expected pinned container comment for %s", image)
}
if !strings.Contains(yamlStr, pinnedImage) {
t.Errorf("Expected pinned download reference for %s", image)
}
}
Comment on lines +50 to +69

for _, imageTagPart := range []string{
`imageTag`,
`0.27.0,`,
`agent=sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248`,
`api-proxy=sha256:f28d2bd3197fb6ef9ec40ef345bbf2bb33e50151a8e72e89abb618fc3d0066eb`,
`squid=sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6`,

@github-actions github-actions Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing cli-proxy digest assertion in imageTagPart checks: buildAWFImageTagWithDigests unconditionally appends cli-proxy=sha256:... to the AWF imageTag whenever that pin is available — and cli-proxy:0.27.0 is now embedded. The generated imageTag for v0.27.0 will be 0.27.0,squid=...,agent=...,api-proxy=...,cli-proxy=..., but the test does not verify the cli-proxy component. A regression that dropped cli-proxy from the imageTag computation would go undetected.

💡 Suggested fix

Add a sixth entry to the imageTagPart slice:

`squid=sha256:d6a01d4cf3d928e6a7fc42e34afef228e753dce87646edc91d8a5cd0b612d9a6`,
`cli-proxy=sha256:42529ecb9f90da5adb00593d268dfdbd35d14bb1dc92dd897286b27ce1e3d58d`,

Note: cli-proxy intentionally stays out of expectedPins (the manifest-header / pull-list check), because isCliProxyNeeded is false for this test workflow. Only the AWF config imageTag field needs the extra assertion.

} {
if !strings.Contains(yamlStr, imageTagPart) {
t.Errorf("Expected AWF config JSON to include %s", imageTagPart)
}
}
}
7 changes: 7 additions & 0 deletions pkg/workflow/docker_pin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ func TestApplyContainerPins(t *testing.T) {
expectedRefs: []string{"node:lts-alpine@sha256:2bdb65ed1dab192432bc31c95f94155ca5ad7fc1392fb7eb7526ab682fa5bf14"},
expectedDigests: []string{"sha256:2bdb65ed1dab192432bc31c95f94155ca5ad7fc1392fb7eb7526ab682fa5bf14"},
},
{
name: "embedded firewall pin used when cache is absent",
images: []string{"ghcr.io/github/gh-aw-firewall/agent:0.27.0"},
pins: nil,
expectedRefs: []string{"ghcr.io/github/gh-aw-firewall/agent:0.27.0@sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248"},
expectedDigests: []string{"sha256:3816d1692e6d96887b27f1e4f1d64b8d7edb43ed9d7506b8f203913cbb81c248"},
},
{
name: "pinned image replaced with digest reference",
images: []string{"node:lts-alpine"},
Expand Down
Loading