[dead-code] chore: remove dead functions — 5 functions removed

pkg/cli/mcp_helpers.go

@@ -7,7 +7,6 @@ package cli
 import (
 	"fmt"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"strings"
 
@@ -85,11 +84,3 @@ func withNonInteractiveCIEnv(env []string) []string {
 
 	return append(env, "CI=1")
 }
-
-func setNonInteractiveCIEnv(cmd *exec.Cmd) {
-	if cmd == nil {
-		return
-	}
-
-	cmd.Env = withNonInteractiveCIEnv(cmd.Env)
-}

pkg/cli/mcp_validation_test.go

@@ -4,7 +4,6 @@ package cli
 
 import (
 	"os"
-	"os/exec"
 	"path/filepath"
 	"testing"
 
@@ -61,7 +60,7 @@ func TestGetBinaryPath(t *testing.T) {
 	})
 }
 
-func TestSetNonInteractiveCIEnv(t *testing.T) {
+func TestWithNonInteractiveCIEnv(t *testing.T) {
 	t.Run("returns copied env with CI forced on", func(t *testing.T) {
 		input := []string{"CI=false", "HOME=/tmp/test-home"}
 
@@ -74,23 +73,12 @@ func TestSetNonInteractiveCIEnv(t *testing.T) {
 	})
 
 	t.Run("adds CI when missing", func(t *testing.T) {
-		cmd := exec.Command("echo")
-		cmd.Env = []string{"HOME=/tmp/test-home"}
+		input := []string{"HOME=/tmp/test-home"}
 
-		setNonInteractiveCIEnv(cmd)
-
-		assert.Contains(t, cmd.Env, "CI=1")
-		assert.Contains(t, cmd.Env, "HOME=/tmp/test-home")
-	})
-
-	t.Run("overrides existing CI value", func(t *testing.T) {
-		cmd := exec.Command("echo")
-		cmd.Env = []string{"CI=false", "HOME=/tmp/test-home"}
-
-		setNonInteractiveCIEnv(cmd)
+		output := withNonInteractiveCIEnv(input)
 
-		assert.Contains(t, cmd.Env, "CI=1")
-		assert.NotContains(t, cmd.Env, "CI=false")
-		assert.Contains(t, cmd.Env, "HOME=/tmp/test-home")
+		assert.Equal(t, []string{"HOME=/tmp/test-home"}, input, "must not mutate input")
+		assert.Contains(t, output, "CI=1")
+		assert.Contains(t, output, "HOME=/tmp/test-home")
 	})
 }

pkg/cli/outcome_domain_breakdown.go

@@ -2,7 +2,6 @@ package cli
 
 import (
 	"cmp"
-	"fmt"
 	"slices"
 	"strings"
 
@@ -111,70 +110,3 @@ func countTotalAttempted(breakdowns []DomainBreakdown) int {
 	}
 	return total
 }
-
-// DomainInsight provides a human-readable assessment of a domain's performance.
-type DomainInsight struct {
-	Label      string
-	Status     string // "excellent", "good", "fair", "poor", "new"
-	Efficiency float64
-	Message    string
-	Suggestion string
-}
-
-// AnalyzeDomainPerformance provides strategic insights about domain efficiency.
-func AnalyzeDomainPerformance(breakdown DomainBreakdown) DomainInsight {
-	insight := DomainInsight{
-		Label:      breakdown.Label,
-		Efficiency: breakdown.ObjectiveEfficiency,
-	}
-
-	if breakdown.Attempted == 0 {
-		insight.Status = "new"
-		insight.Message = "No outcomes yet"
-		return insight
-	}
-
-	switch {
-	case breakdown.ObjectiveEfficiency >= 0.90:
-		insight.Status = "excellent"
-		insight.Message = fmt.Sprintf("✅ %s: %.0f%% efficiency | %d/%d outcomes accepted | %d value delivered",
-			breakdown.Label,
-			breakdown.ObjectiveEfficiency*100,
-			breakdown.Accepted,
-			breakdown.Attempted,
-			breakdown.AcceptedObjectiveValue)
-		insight.Suggestion = "Keep current strategy working well"
-
-	case breakdown.ObjectiveEfficiency >= 0.75:
-		insight.Status = "good"
-		insight.Message = fmt.Sprintf("✅ %s: %.0f%% efficiency | %d/%d outcomes accepted | %d value delivered",
-			breakdown.Label,
-			breakdown.ObjectiveEfficiency*100,
-			breakdown.Accepted,
-			breakdown.Attempted,
-			breakdown.AcceptedObjectiveValue)
-		insight.Suggestion = "Good progress; monitor for regressions"
-
-	case breakdown.ObjectiveEfficiency >= 0.50:
-		insight.Status = "fair"
-		insight.Message = fmt.Sprintf("⚠️ %s: %.0f%% efficiency | %d/%d outcomes accepted | %d value delivered",
-			breakdown.Label,
-			breakdown.ObjectiveEfficiency*100,
-			breakdown.Accepted,
-			breakdown.Attempted,
-			breakdown.AcceptedObjectiveValue)
-		insight.Suggestion = "Consider reviewing agent strategy or adding human review"
-
-	default:
-		insight.Status = "poor"
-		insight.Message = fmt.Sprintf("🔴 %s: %.0f%% efficiency | %d/%d outcomes accepted | %d value delivered",
-			breakdown.Label,
-			breakdown.ObjectiveEfficiency*100,
-			breakdown.Accepted,
-			breakdown.Attempted,
-			breakdown.AcceptedObjectiveValue)
-		insight.Suggestion = "Major issues; investigate root cause or pause automation"
-	}
-
-	return insight
-}

pkg/parser/import_bfs.go

@@ -380,55 +380,6 @@ func enqueueNestedImports(frontmatter map[string]any, item importQueueItem, base
 	return nil
 }
 
-func parseNestedImportEntries(frontmatter map[string]any) []nestedImportEntry {
-	importsField, hasImports := frontmatter["imports"]
-	if !hasImports {
-		return nil
-	}
-	switch v := importsField.(type) {
-	case []any:
-		nestedImports := make([]nestedImportEntry, 0, len(v))
-		for _, item := range v {
-			entry, ok := parseNestedImportEntry(item)
-			if !ok {
-				continue
-			}
-			nestedImports = append(nestedImports, entry)
-		}
-		return nestedImports
-	case []string:
-		return nestedEntriesFromSpecs(importSpecsFromStringSlice(v))
-	default:
-		return nil
-	}
-}
-
-func parseNestedImportEntry(item any) (nestedImportEntry, bool) {
-	switch nestedItem := item.(type) {
-	case string:
-		return nestedImportEntry{path: nestedItem}, true
-	case map[string]any:
-		var nestedPath string
-		if usesPath, ok := nestedItem["uses"].(string); ok {
-			nestedPath = usesPath
-		} else if pathVal, ok := nestedItem["path"].(string); ok {
-			nestedPath = pathVal
-		}
-		if nestedPath == "" {
-			return nestedImportEntry{}, false
-		}
-		var nestedInputs map[string]any
-		if withVal, ok := nestedItem["with"].(map[string]any); ok {
-			nestedInputs = withVal
-		} else if inputsVal, ok := nestedItem["inputs"].(map[string]any); ok {
-			nestedInputs = inputsVal
-		}
-		return nestedImportEntry{path: nestedPath, inputs: nestedInputs}, true
-	default:
-		return nestedImportEntry{}, false
-	}
-}
-
 func nestedEntriesFromSpecs(specs []ImportSpec) []nestedImportEntry {
 	nestedImports := make([]nestedImportEntry, 0, len(specs))
 	for _, spec := range specs {

pkg/parser/import_bfs_test.go

@@ -9,25 +9,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestParseNestedImportEntries_LenientArrayParsing(t *testing.T) {
-	frontmatter := map[string]any{
-		"imports": []any{
-			"valid-a.md",
-			map[string]any{"path": "valid-b.md", "inputs": map[string]any{"env": "prod"}},
-			map[string]any{"path": 123},
-			map[string]any{"inputs": map[string]any{"env": "ignored"}},
-			42,
-		},
-	}
-
-	entries := parseNestedImportEntries(frontmatter)
-	require.Len(t, entries, 2)
-	require.Equal(t, "valid-a.md", entries[0].path)
-	require.Nil(t, entries[0].inputs)
-	require.Equal(t, "valid-b.md", entries[1].path)
-	require.Equal(t, map[string]any{"env": "prod"}, entries[1].inputs)
-}
-
 func TestParseImportSpecsFromArray_RejectsIfField(t *testing.T) {
 	_, err := parseImportSpecsFromArray([]any{
 		map[string]any{

pkg/workflow/compilerenv/manager.go

@@ -46,26 +46,6 @@ const (
 	DefaultModelCodex = "GH_AW_DEFAULT_MODEL_CODEX"
 )
 
-// ResolveDefaultMaxDailyAICredits returns the resolved daily AI Credits guardrail
-// default, checking the enterprise env var GH_AW_DEFAULT_MAX_DAILY_AI_CREDITS.
-// Falls back to fallback (built-in default) when the env var is unset or invalid.
-//
-// A value of -1 is preserved to allow explicitly disabling the guardrail.
-func ResolveDefaultMaxDailyAICredits(fallback string) string {
-	if raw := strings.TrimSpace(os.Getenv(DefaultMaxDailyAICredits)); raw != "" {
-		if raw == "-1" {
-			managerLog.Printf("Applying enterprise override %s=%q (fallback was %q)", DefaultMaxDailyAICredits, raw, fallback)
-			return "-1"
-		}
-		if normalized, ok := typeutil.NormalizeInt64KMSuffix(raw); ok {
-			managerLog.Printf("Applying enterprise override %s=%q (fallback was %q)", DefaultMaxDailyAICredits, normalized, fallback)
-			return normalized
-		}
-		managerLog.Printf("Invalid %s=%q, using fallback=%q", DefaultMaxDailyAICredits, raw, fallback)
-	}
-	return fallback
-}
-
 // ResolveDefaultMaxAICredits returns the resolved max AI credits default, checking
 // the enterprise env var GH_AW_DEFAULT_MAX_AI_CREDITS.
 // Falls back to fallback (built-in default) when the env var is unset or invalid.

pkg/workflow/compilerenv/manager_test.go

@@ -6,38 +6,6 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestResolveDefaultMaxDailyAICredits(t *testing.T) {
-	t.Run("unset uses fallback", func(t *testing.T) {
-		t.Setenv(DefaultMaxDailyAICredits, "")
-		assert.Equal(t, "5000", ResolveDefaultMaxDailyAICredits("5000"))
-	})
-
-	t.Run("invalid uses fallback", func(t *testing.T) {
-		t.Setenv(DefaultMaxDailyAICredits, "abc")
-		assert.Equal(t, "5000", ResolveDefaultMaxDailyAICredits("5000"))
-	})
-
-	t.Run("zero uses fallback", func(t *testing.T) {
-		t.Setenv(DefaultMaxDailyAICredits, "0")
-		assert.Equal(t, "5000", ResolveDefaultMaxDailyAICredits("5000"))
-	})
-
-	t.Run("valid value overrides fallback", func(t *testing.T) {
-		t.Setenv(DefaultMaxDailyAICredits, "1000000")
-		assert.Equal(t, "1000000", ResolveDefaultMaxDailyAICredits("5000"))
-	})
-
-	t.Run("suffix value overrides fallback", func(t *testing.T) {
-		t.Setenv(DefaultMaxDailyAICredits, "2M")
-		assert.Equal(t, "2000000", ResolveDefaultMaxDailyAICredits("5000"))
-	})
-
-	t.Run("disables guardrail with -1", func(t *testing.T) {
-		t.Setenv(DefaultMaxDailyAICredits, "-1")
-		assert.Equal(t, "-1", ResolveDefaultMaxDailyAICredits("5000"))
-	})
-}
-
 func TestResolveDefaultMaxAICredits(t *testing.T) {
 	t.Run("unset uses fallback", func(t *testing.T) {
 		t.Setenv(DefaultMaxAICredits, "")

pkg/workflow/compilerenv/spec_test.go

@@ -63,9 +63,9 @@ func TestSpec_DailyAICreditsGuardrail_ExpressionForm(t *testing.T) {
 
 // TestSpec_DailyAICreditsGuardrail_RuntimeNotCompileTime validates AIC spec §9.3 (2):
 // GH_AW_DEFAULT_MAX_DAILY_AI_CREDITS MUST be resolved at action runtime, not at
-// compiler process environment lookup. The BuildDefaultMaxDailyAICreditsExpression
-// function is the conforming API; ResolveDefaultMaxDailyAICredits is retained for
-// other compile-time uses but MUST NOT be called for the daily guardrail default path.
+// compiler process environment lookup. BuildDefaultMaxDailyAICreditsExpression is
+// the sole conforming API for this path; the compile-time resolver
+// ResolveDefaultMaxDailyAICredits has been removed as dead code.
 //
 // T-AIC-DG-006: The compiler produces an expression, not a pre-resolved value.
 func TestSpec_DailyAICreditsGuardrail_RuntimeNotCompileTime(t *testing.T) {

specs/objective-mapping-portfolio-reporting.md

@@ -498,9 +498,6 @@ type DomainBreakdown struct {
 
 // Aggregate outcomes by objective label
 func ComputeDomainBreakdowns(reports []OutcomeReport) []DomainBreakdown
-
-// Generate strategic insight
-func AnalyzeDomainPerformance(breakdown DomainBreakdown) DomainInsight
 ```
 
 ## Testing