Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v0.8.0 release for both the twirp runtime and twirp-build code generation crates. The key changes include bumping the version numbers from 0.7.0 to 0.8.0 and the removal of the explicit "license" field in favor of using the "license-file" field.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/twirp/Cargo.toml | Updated version and removed the "license" field. |
| crates/twirp-build/Cargo.toml | Updated version and removed the "license" field. |
Comments suppressed due to low confidence (2)
crates/twirp/Cargo.toml:13
- Consider whether removing the 'license' field aligns with project standards for displaying license metadata. If intentional, add a comment or update documentation to explain the change.
-license = "MIT"
crates/twirp-build/Cargo.toml:13
- Consider whether removal of the 'license' field in favor of only the 'license-file' field will affect how the license is displayed on crates.io. If this is intentional, please update documentation to clarify.
-license = "MIT"
tclem
approved these changes
Apr 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has already been published to crates.io as twirp 0.8.0 and twirp-build 0.8.0.