Skip to content
This repository was archived by the owner on Apr 19, 2018. It is now read-only.
This repository was archived by the owner on Apr 19, 2018. It is now read-only.

Grit::Repo.grep returns separated list if --\n is in file context #27

Description

@coverer

The search of gitlab (and almost every other thing depending on grit) could be improved,
when in lib/grit/repo.rb line 724 would be changed from

722       binary = false
723       file = ''
724        matches = filematch.split("--\n")
725        matches.each_with_index do |match, i|
726          content = []

to use a regexp instead of a string as split parameter

722       binary = false
723       file = ''
724        matches = filematch.split(/^--\n/)
725        matches.each_with_index do |match, i|
726          content = []

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions