fix: register CSI ^ as scroll down alias#10
Merged
Conversation
CSI Ps ^ is an alias for CSI Ps T (scroll down) added in upstream xterm.js commit da4243c. Without this handler, the sequence is silently ignored. Fixes #1 Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream xterm.js added
CSI Ps ^as an alias forCSI Ps T(scroll down) in commitda4243c. The Go port did not register this handler, causing the sequence to be silently ignored.Fix
Register
CSI ^mapped to the existingscrollDownhandler, matching the upstream behavior.Tests
Added two test cases to
TestScrollUpDown:SD_scroll_down_caret_alias— verifiesCSI 1 ^scrolls down by 1 (same asCSI 1 T)SD_scroll_down_caret_2— verifiesCSI 2 ^scrolls down by 2Fixes #1