Housekeeping: Generate output files on prepublish; remove them from git - #118
Open
anko wants to merge 5 commits into
Open
Housekeeping: Generate output files on prepublish; remove them from git#118anko wants to merge 5 commits into
anko wants to merge 5 commits into
Conversation
This lets us remove them from Git tracking. They're bloating the diff of every commit completely unnecessarily. The prepublish hook https://docs.npmjs.com/misc/scripts runs automatically before `npm publish`, and local `npm install`, ensuring the built JS files are in place when needed.
anko
changed the title
Since it's no longer checked in.
Author
|
Egch. 😠 Travis is failing to run I think having a build metadata file ( |
I think having a build metadata file (`package.json.ls`) that needs to be built first _using one of the dependencies that it is specifying_ is a bad idea. Let's just use package.json.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am irritated by how much the generated files in
lib/bloat the git tree when I commit to this project. It's unnecessary to check in generated output files!The
prepublishhook takes care that the output files are built onnpm publishor localnpm install.For prior art doing this type of thing with a LiveScript library, see—
lsconprepublish), ormakeonprepare).Both store only check in the source LiveScript, not the generated JS.