fix: restore interactive prompts during installation#18
Merged
glauberlima merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
`is_piped()` was checking stdout (fd 1), but prompt functions are called inside `$(...)` command substitutions where stdout is always a pipe. This caused every interactive prompt to be silently skipped. Switching to stderr (fd 2) fixes the regression: stderr is inherited through subshells unchanged, correctly reflecting whether a real terminal is present in all scenarios (direct run, curl|bash, CI/redirect).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_piped()checked stdout (fd 1), causing all interactive prompts (language and component selection) to be silently skipped$(...)command substitutions, where stdout is always a pipe — so[[ ! -t 1 ]]always returnedtrue, even in a real terminalBehavior across scenarios
./install.shin terminalcurl url | bash./install.sh > log 2>&1Test plan
./install.shlocally and confirm language + component selection prompts appear./tests/shellcheck.sh— all checks pass