refactor: simplify patch-statusline.sh and install.sh#21
Merged
glauberlima merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
- patch-statusline.sh: extract _replace_marker_block() shared helper, removing duplicated mktemp/sed/chmod/mv pattern from both replace_config_block() and replace_messages_block(); drop GNU-only chmod --reference in favour of plain chmod +x - install.sh: replace local -r with local (7 sites) for bash 3.2 compatibility; merge download_with_retry() into download_file(), eliminating the thin wrapper and its SC2310 suppression; pre-extract version strings in check_dependencies() to remove 4x SC2312 suppressions; simplify generate_timestamp() fallback to plain date +%s, removing remaining SC2312 suppression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch-statusline.sh: extract _replace_marker_block() shared helper, removing duplicated mktemp/sed/chmod/mv pattern from both replace_config_block() and replace_messages_block(); drop GNU-only chmod --reference in favour of plain chmod +x
install.sh: replace local -r with local (7 sites) for bash 3.2 compatibility; merge download_with_retry() into download_file(), eliminating the thin wrapper and its SC2310 suppression; pre-extract version strings in check_dependencies() to remove 4x SC2312 suppressions; simplify generate_timestamp() fallback to plain date +%s, removing remaining SC2312 suppression