ci: repair the clang-format and gersemi checks - #334
Conversation
Homebrew no longer runs formula install steps from untrusted third party taps, so the gersemi check fails while installing the formatter: Skipping obsproject/tools because it is not trusted. Error: unknown install step: run Refresh the Homebrew metadata and trust the obsproject/tools tap explicitly before installing, mirroring the fix applied upstream in obs-studio. Signed-off-by: EdueskaWeiz <48769486+EdueskaWeiz@users.noreply.github.com>
Same failure mode as the gersemi check: Homebrew refuses to run formula install steps from an untrusted third party tap, so installing clang-format@19 aborts with 'unknown install step: run'. Refresh the Homebrew metadata and trust the obsproject/tools tap before installing. The pinned clang-format 19.1.1 required by build-aux/run-clang-format is unchanged. Signed-off-by: EdueskaWeiz <48769486+EdueskaWeiz@users.noreply.github.com>
|
Two notes so this is not misleading when you look at it:
The real proof is #333, which touches |
|
Looks good. I'm going to squash the two commits together as they are effectively the same change, just in two different paths. The CI build completed fine. |
|
Side note; I'm not excided about the non email address you're using in your SignedOff by. That's not actually helpful as it isn't a way to contact you. Are you able to use a real email address? |
|
Yes, of course — sorry about that. I had "Keep my email addresses private" enabled on my account, and since I created those commits through the web editor, GitHub substituted the noreply address without me noticing. Fixed now. My git config uses While rewriting them I rebased onto current Thanks for squashing the two commits — that was the right call, they were the same change in two paths. |
|
Thanks Eddy. I appreciate the work you're doing on the plugin |
Both format checks currently fail on every PR that touches C/C++ or CMake files, because Homebrew no longer runs formula install steps from an untrusted third party tap:
The failure happens in the install step, not in the formatting itself, so it is unrelated to the contents of the PR being checked (see the red clang-format / gersemi checks on #333).
Fix: refresh the Homebrew metadata and trust the
obsproject/toolstap before installing the formatters. This mirrors the change obs-studio applied upstream in.github/actions/run-clang-formatand.github/actions/run-gersemi.The pinned tool versions are deliberately left untouched (clang-format 19.1.1 as required by
build-aux/run-clang-format, and the tap's defaultgersemiformula), so no reformatting of existing files is expected.