Skip to content

ci: repair the clang-format and gersemi checks - #334

Closed
EdueskaWeiz wants to merge 2 commits into
glikely:mainfrom
EdueskaWeiz:patch-2
Closed

ci: repair the clang-format and gersemi checks#334
EdueskaWeiz wants to merge 2 commits into
glikely:mainfrom
EdueskaWeiz:patch-2

Conversation

@EdueskaWeiz

Copy link
Copy Markdown
Contributor

Both format checks currently fail on every PR that touches C/C++ or CMake files, because Homebrew no longer runs formula install steps from an untrusted third party tap:

Skipping obsproject/tools because it is not trusted. Run `brew trust obsproject/tools`
Error: unknown install step: run

The failure happens in the install step, not in the formatting itself, so it is unrelated to the contents of the PR being checked (see the red clang-format / gersemi checks on #333).

Fix: refresh the Homebrew metadata and trust the obsproject/tools tap before installing the formatters. This mirrors the change obs-studio applied upstream in .github/actions/run-clang-format and .github/actions/run-gersemi.

The pinned tool versions are deliberately left untouched (clang-format 19.1.1 as required by build-aux/run-clang-format, and the tap's default gersemi formula), so no reformatting of existing files is expected.

Homebrew no longer runs formula install steps from untrusted third party taps, so the gersemi check fails while installing the formatter:

  Skipping obsproject/tools because it is not trusted.
  Error: unknown install step: run

Refresh the Homebrew metadata and trust the obsproject/tools tap explicitly before installing, mirroring the fix applied upstream in obs-studio.

Signed-off-by: EdueskaWeiz <48769486+EdueskaWeiz@users.noreply.github.com>
Same failure mode as the gersemi check: Homebrew refuses to run formula install steps from an untrusted third party tap, so installing clang-format@19 aborts with 'unknown install step: run'.

Refresh the Homebrew metadata and trust the obsproject/tools tap before installing. The pinned clang-format 19.1.1 required by build-aux/run-clang-format is unchanged.

Signed-off-by: EdueskaWeiz <48769486+EdueskaWeiz@users.noreply.github.com>
@EdueskaWeiz

Copy link
Copy Markdown
Contributor Author

Two notes so this is not misleading when you look at it:

  • The workflow on this PR is waiting for your approval, so the Checks tab is currently empty.
  • Even once it runs, the checks on this PR will pass trivially: check-changes filters on '*.c' '*.h' '*.cpp' '*.hpp' '*.m' '*.mm' and '*.cmake' '*CMakeLists.txt', and this PR only touches .yaml. So hasChangedFiles is false and the Homebrew install step is skipped entirely.

The real proof is #333, which touches src/ptz-action-source.c and shared/properties-view/CMakeLists.txt and therefore does exercise the install step. Re-running its checks after merging this should show them green.

@glikely

glikely commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Looks good. I'm going to squash the two commits together as they are effectively the same change, just in two different paths. The CI build completed fine.

@glikely

glikely commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Side note; I'm not excided about the non email address you're using in your SignedOff by. That's not actually helpful as it isn't a way to contact you. Are you able to use a real email address?

@glikely glikely closed this Aug 8, 2026
@EdueskaWeiz

Copy link
Copy Markdown
Contributor Author

Yes, of course — sorry about that. I had "Keep my email addresses private" enabled on my account, and since I created those commits through the web editor, GitHub substituted the noreply address without me noticing.

Fixed now. My git config uses eddyweiz@gmail.com, and I have rewritten the four commits on #333 so that both the author and the Signed-off-by line carry it. The patches themselves are byte-for-byte unchanged — I diffed the old and new series against each other to be sure.

While rewriting them I rebased onto current main, which now includes your squash of this PR. That also means #333 picks up the brew trust fix, so the two formatter checks there should finally go green rather than failing on the Homebrew install step. CI is running on the new head now and did not need approval this time.

Thanks for squashing the two commits — that was the right call, they were the same change in two paths.

@glikely

glikely commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Thanks Eddy. I appreciate the work you're doing on the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants