Skip to content

Website accessibility improvements#352

Open
lsfgrd wants to merge 4 commits into
globocom:masterfrom
lsfgrd:a11y_improvements
Open

Website accessibility improvements#352
lsfgrd wants to merge 4 commits into
globocom:masterfrom
lsfgrd:a11y_improvements

Conversation

@lsfgrd

@lsfgrd lsfgrd commented Oct 3, 2021

Copy link
Copy Markdown

Related Issue

None

Proposed Changes

  • Remove the outline:none from the plugin button's focused state. It was practically impossible to navigate these buttons with the keyboard without outlines. I also propose adding a condition to only render the "collapsed" state if the user clicks the "+" button instead of having it rendered all the time but not visible. Check the demo bellow;
Screen.Recording.2021-10-03.at.11.05.25.mov
  • Add the aria-label attribute to the "+/x" button to indicate the respective action to screen readers;
  • Add alt text to the logo so screen readers can understand it's a logo;
  • Add the lang property to the html tag to indicate the content's language declaratively.

This is the Lighthouse rating before the changes:
image

After the changes:
image

Here you can see some improvement on SEO and Performance as well.

The Best Practices metric went down due to dev environment not using HTTPs. It should be good live.

@stale

stale Bot commented Dec 18, 2021

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix label Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant