Website accessibility improvements#352
Open
lsfgrd wants to merge 4 commits into
Open
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
None
Proposed Changes
outline:nonefrom the plugin button's focused state. It was practically impossible to navigate these buttons with the keyboard without outlines. I also propose adding a condition to only render the "collapsed" state if the user clicks the "+" button instead of having it rendered all the time but not visible. Check the demo bellow;Screen.Recording.2021-10-03.at.11.05.25.mov
aria-labelattribute to the "+/x" button to indicate the respective action to screen readers;langproperty to thehtmltag to indicate the content's language declaratively.This is the Lighthouse rating before the changes:

After the changes:

Here you can see some improvement on SEO and Performance as well.
The Best Practices metric went down due to dev environment not using HTTPs. It should be good live.