Skip to content

fix: Only first artist gets written in albums with multiple artists #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SiddharthManthan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Only first artist gets written in albums with multiple artists #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions gamdl/downloader/downloader_song.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,24 @@ async def get_download_item(
)

webplayback = await self.interface.apple_music_api.get_webplayback(song_id)

album_id = webplayback.get("songList", [{}])[0].get("assets", [{}])[0].get("metadata", {}).get("playlistId")
album_metadata = None
if album_id:
try:
album_response = await self.interface.apple_music_api.get_album(str(album_id))
if album_response and "data" in album_response and len(album_response["data"]) > 0:
album_metadata = album_response["data"][0]
except Exception:
pass

download_item.media_tags = await self.interface.get_tags(
webplayback,
download_item.lyrics.unsynced if download_item.lyrics else None,
album_metadata,
self.use_album_date,
)

if self.fetch_extra_tags:
download_item.extra_tags = await self.interface.get_extra_tags(
song_metadata,
Expand Down
7 changes: 6 additions & 1 deletion gamdl/interface/interface_song.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,18 @@ async def get_tags(
self,
webplayback: dict,
lyrics: str | None = None,
album_metadata: dict | None = None,
use_album_date: bool = False,
) -> MediaTags:
webplayback_metadata = webplayback["songList"][0]["assets"][0]["metadata"]

tags = MediaTags(
album=webplayback_metadata["playlistName"],
album_artist=webplayback_metadata["playlistArtistName"],
album_artist=(
album_metadata.get("attributes", {}).get("artistName")
if album_metadata
else webplayback_metadata["playlistArtistName"]
),
album_id=int(webplayback_metadata["playlistId"]),
album_sort=webplayback_metadata["sort-album"],
artist=webplayback_metadata["artistName"],
Expand Down