fix (alac): resolution for incorrect duration tags in ALAC downloads#289
Open
SiddharthManthan wants to merge 1 commit intoglomatico:mainfrom
Open
fix (alac): resolution for incorrect duration tags in ALAC downloads#289SiddharthManthan wants to merge 1 commit intoglomatico:mainfrom
SiddharthManthan wants to merge 1 commit intoglomatico:mainfrom
Conversation
- Updated amdecrypt.py to correctly patch both timescale and duration in mdhd boxes (support for v0 and v1) - Added tag filtering in downloader_base.py and interface_song.py to prevent preview-related tags (e.g., ©dur, iTunSMPB) from overwriting full-track metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285
Credits : bascurtiz