Open
Conversation
This adds the syllable_lyrics endpoint for ttml and prefers those over the lyrics in the metadata, if available. It falls back to the metadata lyrics if they are not.
|
Would it be possible to have the option of embedding line-synced lyrics in the audio file, whilst having syllable-lyrics download in an external .ttml file? If no syllable-lyrics exist for the given track , it should just skip the external file. Great work on this PR, hopefully it gets merged ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the syllable_lyrics endpoint for ttml and prefers those over the lyrics in the metadata, if available. It falls back to the metadata lyrics if they are not.