Improve compatibility with Anki 2.1.41+#179
Open
bentyeh wants to merge 1 commit intoglutanimate:masterfrom
Open
Improve compatibility with Anki 2.1.41+#179bentyeh wants to merge 1 commit intoglutanimate:masterfrom
bentyeh wants to merge 1 commit intoglutanimate:masterfrom
Conversation
Fixes RL button to correctly insert `class="shuffle"` into `<ul>` element, thereby allowing shuffling to work correctly in Anki 2.1.41+. - [Anki 2.1.41](https://forums.ankiweb.net/t/add-on-porting-notes-for-anki-2-1-41/7390) requires using `.getSelection()` on a field instead of `window`. This pull request does NOT fix the yellow background highlight for random lists - i.e., shuffled lists are still NOT highlighted as intended.
4 tasks
|
Do you know how to fix this "This pull request does NOT fix the yellow background highlight for random lists"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RL button to correctly insert
class="shuffle"into<ul>element, thereby allowing shuffling to work correctly in Anki 2.1.41+, which requires using.getSelection()on a field instead ofwindow.This pull request does NOT fix the yellow background highlight for random lists - i.e., shuffled lists are still NOT highlighted as intended.