Add Update, remove key for Trie - #10
Open
k-sae wants to merge 8 commits into
Open
Conversation
add test casses for the condition key is a part of longer key add remove to the iTrie interface add unimpelemnted remove function for all the inherited tries
fix some bugs in the Remove functio
the function may encounter
fix some backward uncompatibility with the add / remove tests
|
@k-sae Can you fix the CI build issue? I'm using this package would need Update and Remove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i have added the update and remove implementation for TrieNodeBase
the user can use
ITrie<int> trie = new Trie<int>();trie.delete(key) // worksthe rest of the algorithms delete and update were left unimplemented
ITrie<int> trie = new SuffixTrie<int>();trie.delete(key) // throws unimplemented exception