Skip to content

fix: normalize token symbols/logos in incentivize history#863

Open
jinoosss wants to merge 1 commit intodevelopfrom
GSW-2629-fix-incentive-history-pool-token-symbol
Open

fix: normalize token symbols/logos in incentivize history#863
jinoosss wants to merge 1 commit intodevelopfrom
GSW-2629-fix-incentive-history-pool-token-symbol

Conversation

@jinoosss
Copy link
Copy Markdown
Member

@jinoosss jinoosss commented Apr 21, 2026

Descriptions

  • Fixes token symbol/logo rendering in IncentivizePoolHistoryBox by normalizing pool token metadata through getGnotPath.
  • Ensures wrapped/native GNOT variants are displayed consistently in incentive history rows.
  • Refactors pool memoization logic to safely handle missing pool data before mapping token metadata.

Changes

  • Added useGnotToGnot hook usage in IncentivizePoolHistoryBox.
  • Updated currentPool memo logic to:
    • return early when pool is unavailable
    • map tokenA and tokenB symbol/logo values via getGnotPath(...)

Motivation

Incentive history could show inconsistent token symbols/logos depending on wrapped/native token representation. This change standardizes display output for better UX and data clarity.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected token symbol and logo display in the pool incentivization history view to ensure accurate token information is shown for all assets.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gnoswap-interface Ready Ready Preview, Comment Apr 21, 2026 3:20am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Walkthrough

This PR enhances the IncentivizePoolHistoryBox component by integrating GNOT-to-GNOT path conversion functionality. The changes use the useGnotToGnot hook to augment pool token metadata (symbol and logoURI) with GNOT conversion paths, and updates memoization dependencies accordingly.

Changes

Cohort / File(s) Summary
GNOT Token Metadata Enhancement
packages/web/src/layouts/pool/pool-incentivize/components/incentivize-pool-history/incentivize-pool-history-box/IncentivizePoolHistoryBox.tsx
Integrated useGnotToGnot hook and getGnotPath extraction to augment tokenA and tokenB metadata with GNOT conversion paths. Updated currentPool memoization to override token symbols and logoURIs. Updated dependency array to include getGnotPath.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'fix: normalize token symbols/logos in incentivize history' accurately describes the main change: normalizing token symbols and logos in the incentivize history component using the getGnotPath hook.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch GSW-2629-fix-incentive-history-pool-token-symbol

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: deae4f76-88ae-4492-b14e-9093e5b30295

📥 Commits

Reviewing files that changed from the base of the PR and between 573ad02 and f8c526e.

📒 Files selected for processing (1)
  • packages/web/src/layouts/pool/pool-incentivize/components/incentivize-pool-history/incentivize-pool-history-box/IncentivizePoolHistoryBox.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant