middleware: GetHead advertises HEAD in the 405 Allow header#1095
Open
c-tonneslan wants to merge 1 commit into
Open
middleware: GetHead advertises HEAD in the 405 Allow header#1095c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
GetHead routes undefined HEAD requests through the matching GET handler, but the Allow header on a 405 response only came from the methods explicitly registered with the router. A GET-only route returned `Allow: GET` and never mentioned the implicit HEAD support, which left clients thinking HEAD wasn't allowed when in fact it was. Wrap the response writer and add HEAD to the Allow header at WriteHeader time when the response is a 405 and Allow already lists GET. Existing responses without GET, and 405s where HEAD is already present, are left alone. Closes go-chi#1030. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1030.
`GetHead` routes undefined HEAD requests through the matching GET handler, but the Allow header on a 405 response only came from the methods explicitly registered with the router. A GET-only route returned `Allow: GET` and never mentioned the implicit HEAD support, so clients thought HEAD wasn't allowed when in fact it was.
Wrap the response writer and add HEAD to the Allow header at `WriteHeader` time when the response is a 405 and Allow already lists GET. Responses without GET, and 405s where HEAD is already in Allow, are left alone.
Added `TestGetHead_AllowHeaderIncludesHead` covering the regression.