middleware: handle Host routing via Request.Host#1118
Closed
happysnaker wants to merge 1 commit into
Closed
Conversation
Signed-off-by: happysnaker <73147033+happysnaker@users.noreply.github.com>
Contributor
Author
|
Friendly follow-up: this patch keeps the API surface unchanged, but makes Host-based routing line up with how It also adds host-with-port coverage, which seems useful for local development cases like |
Contributor
Author
|
Resubmitted from a restored public fork as #1120. Closing this thread in favor of the new PR so the contribution stays reviewable from a proper fork relationship. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Request.HostforRouteHeadersrules targetingHostnet/httphost promotion behavior in the middleware docsWhy
net/httppromotes the HTTP Host header toRequest.Hostand removes it fromRequest.Header, so the existing Host-based example inRouteHeadersis misleading for normal browser traffic. This patch makes Host routing behave the way users expect and updates the docs/tests accordingly.Closes #691