fix(pull): prevent merge from using stale approvals right after a push - #39199
Open
gomitrah wants to merge 1 commit into
Open
fix(pull): prevent merge from using stale approvals right after a push#39199gomitrah wants to merge 1 commit into
gomitrah wants to merge 1 commit into
Conversation
GiteaBot
added
the
lgtm/need 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39172
Push-triggered stale-review marking/dismissal runs in a detached
goroutine, unsynchronized with merge-time approval checks. A merge
called right after a push can land in that window and use an
approval from the previous head commit.
Both paths now acquire the existing per-PR lock
(
getPullWorkingLockKey), so a merge can't proceed until anyin-flight stale-dismissal work for that PR has finished.
services/pull/pull.go: lock around the stale-marking/dismissalblock in
AddTestPullRequestTaskservices/pull/check.go: lock inCheckPullMergeablebeforebranch protection checks