Skip to content

enhance: improve commit page header - #39229

Open
silverwind wants to merge 3 commits into
go-gitea:mainfrom
silverwind:commit-page-header
Open

enhance: improve commit page header#39229
silverwind wants to merge 3 commits into
go-gitea:mainfrom
silverwind:commit-page-header

Conversation

@silverwind

@silverwind silverwind commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Render authors via avatar stack like other pages already do
  • Center the commit status icon on the text
  • Hide the signature badge for unsigned commits
  • Support rendering plural "N parents" (octopus merge)
  • Add copy button to commit sha
  • Make the header buttons non-primary
  • Remove now-dead CoAuthorIdentities and port its test cases
image image

@silverwind
enhance(repo): align commit page header with GitHub
b76f3cc 
The status icon sat below the title's center line, co-authors rendered
as a separate "co-authored by" list, and the parent and commit hashes
were oversized labels spaced far apart.

Use the avatar stack with GitHub's "authored" and "committed" wording,
hide the badge for unsigned commits, and show the hash group with a
copy button.

Assisted-by: Claude Code:claude-fable-5-1
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 3, 2026
@github-actions github-actions Bot added topic/repo Related to repositories type/enhancement An improvement of existing functionality labels Sep 3, 2026
@silverwind silverwind changed the title enhance(repo): align commit page header with GitHub enhance(repo): enhance commit page header Sep 3, 2026
@silverwind
refactor(git): drop unused CoAuthorIdentities
be87b8e 
The commit page now renders every author through the avatar stack, so
nothing calls it anymore. Its parsing cases move to the AllAuthors test.

Assisted-by: Claude Code:claude-fable-5-1
@silverwind silverwind changed the title enhance(repo): enhance commit page header enhance: improve commit page header Sep 3, 2026
@github-actions github-actions Bot removed the topic/repo Related to repositories label Sep 3, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 3, 2026
@silverwind

silverwind commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

One thing that's probably worth: put the whole sentence as one translation string, <authors> committed <time_ago>.

@silverwind
enhance(repo): translate the commit attribution as one sentence
e27cc95 
Word-by-word keys forced every language into English word order. Pass
the authors, committer and time as arguments to a single string per
case instead.

Assisted-by: Claude Code:claude-fable-5-1
@silverwind

silverwind commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

One thing that's probably worth: put the whole sentence as one translation string, <authors> committed <time_ago>.

done in e27cc95

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bircni bircni bircni approved these changes

Assignees

No one assigned

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silverwind @bircni @GiteaBot