refactor(templates): update djlint to 1.45.1 and fix issues - #39231
Open
silverwind wants to merge 2 commits into
Open
refactor(templates): update djlint to 1.45.1 and fix issues#39231silverwind wants to merge 2 commits into
silverwind wants to merge 2 commits into
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
Bot
added
the
type/refactoring
silverwind
force-pushed
the
djlint-1.45
branch
2 times, most recently
from
September 3, 2026 23:35
026dec3 to
a9e517b
Compare
Member
Author
|
djlint/djLint#2452 was merged and just released, I will update to that and remove the workaround. |
A button without a type is a submit button, so a click or Enter in a form did whatever the markup happened to imply. Buttons that submit their form say submit, everything else says button. Also covers djlint's new H043 rule. Assisted-by: Claude Code:claude-fable-5-1
H045 is ignored because the only iframe is the devtest mail preview. H046 is ignored because the sign-in form orders its tab stops on purpose. Assisted-by: Claude Code:claude-fable-5-1
silverwind
force-pushed
the
djlint-1.45
branch
from
September 4, 2026 18:13
54cd6f4 to
e716f8a
Compare
silverwind
changed the title
silverwind
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeto every<button>,submitwhere it submits its form,buttonelsewhere (H043)<br>spacing with paragraphs and a margin (H036)To ease review, branch has 2 comments, one for buttons, one for the rest.