enhance(issue): add "r" shortcut to quote selected text in a reply - #39232
Open
rspeicher wants to merge 1 commit into
Open
enhance(issue): add "r" shortcut to quote selected text in a reply#39232rspeicher wants to merge 1 commit into
rspeicher wants to merge 1 commit into
Conversation
Selecting text in an issue, pull request or code review comment and pressing "r" now quotes it into the reply editor, the same result as picking Quote Reply from the comment's context menu. With no text selected, or with a selection spanning more than one comment, the key does nothing so it stays out of the way of normal typing. The context menu identified its comment through the clicked item's data-target, which a keystroke does not have, so the comment is resolved from the selection instead and both entry points share the editor lookup. Assisted-by: Claude Code:claude-opus-5[1m]
GiteaBot
added
the
lgtm/need 2
github-actions
Bot
added
topic/issues
type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting text in an issue, pull request, or code review comment and pressing
rquotes it into the reply editor — the same result as Quote Reply in the context menu, which already quotes a selection when one exists. With no selection, or one spanning two comments, the key does nothing.Refs #5796
Not built on the
<kbd>/data-shortcut-keysmodule from #36416, which focuses an input rather than running an action. Happy to generalize that instead.No visual change; a
<kbd>R</kbd>hint on the menu item could be added if wanted.Two reviewer calls:
quote-reply-diffis now unused: both entry points resolve.comment-code-cloudstructurally. Removing it touches five templates, left as a follow-up.editor.value()does not fireEventEditorContentChanged, so the Comment button stays disabled until the user types.Written by Claude Opus 5 (Claude Code).