refactor: replace jquery.are-you-sure with first-party code - #39233
Open
silverwind wants to merge 6 commits into
Open
refactor: replace jquery.are-you-sure with first-party code#39233silverwind wants to merge 6 commits into
silverwind wants to merge 6 commits into
Conversation
The vendored plugin was a @ts-nocheck jQuery fork and the last jQuery consumer outside Fomantic. The replacement keeps the ignore-dirty and ays-ignore template contracts, tracks fields per form with delegated listeners and drops the unused plugin options and jQuery events. The editor marks its commit form wrapper ignored instead of initializing the tracker twice on the same form. Assisted-by: Claude Code:claude-fable-5-1
GiteaBot
added
the
lgtm/need 2
silverwind
changed the title
github-actions
Bot
added
topic/code-linting
type/refactoring
Assisted-by: Claude Code:claude-fable-5-1
Assisted-by: Claude Code:claude-fable-5-1
Assisted-by: Claude Code:claude-fable-5-1
Assisted-by: Claude Code:claude-fable-5-1
Assisted-by: Claude Code:claude-fable-5-1
delvh
approved these changes
Sep 4, 2026
GiteaBot
added
lgtm/need 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the vendored jQuery are-you-sure plugin with a first-party code. The
ignore-dirtyandays-ignoretemplate contracts are kept, the unused plugin options and jQuery events are dropped.ays-ignorealso covers descendants, the file editor uses it on its commit form.<button>elements are untracked, the Chrome double-prompt hack is gone.