decode extended responseName by context class - #605
Merged
cpuschma merged 2 commits intoJul 6, 2026
Conversation
cpuschma
requested changes
Jul 5, 2026
cpuschma
left a comment
Member
There was a problem hiding this comment.
@netliomax25-code Thank you for yor PRs. LGTM, but please take a look at the linting errors. Thank you.
Contributor
Author
|
Fixed. The two errcheck hits were the unchecked Close() returns in the new test's defers; wrapped both to discard the error explicitly. Lint and the Go 1.25/1.26 validation jobs are green now, and the regression test still passes with -race. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conn.Extendedthe ExtendedResponse children are matched onchild.Tagonly: tag 10 setsNameand tag 11 setsValue.responseNameis[10]context-class, but theresultCodethat always precedes it is a universalENUMERATEDwith the same tag number, so the result code matches the name case. When a server omitsresponseName(the usual case),ExtendedResponse.Nameends up holding the raw result code octet ("\x00"on success) instead of an empty string.responseName/responseValueare read. This mirrors the class-aware decoding already used for other controls.Verified with a regression test that drives
Extendedover the in-package fake connection with a success response that carries aresponseValuebut noresponseName; it assertsNameis empty and fails on the current code (Name == "\x00").