Use crypto/sha256 instead of crypto/md5 for FIPS compliance. - #1056
Conversation
|
Not only for fips, many linters now suggest avoiding md5 for any reason. |
|
When running go code using https://go.dev/doc/security/fips140 I will update the comment. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #1056 +/- ##
==========================================
+ Coverage 99.82% 99.85% +0.03%
==========================================
Files 18 18
Lines 3919 3371 -548
==========================================
- Hits 3912 3366 -546
+ Misses 5 3 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeevatkm
left a comment
There was a problem hiding this comment.
@BillBuilt Thanks for the PR. I'm sorry for the delayed response, I was occupied with my personal stuff.
Can you please revert the go.{mod, sum} file changes?
No worries. I reverted the version changes. I did get this warning so maybe consider updating any dependencies when you get a chance.
Thanks again! |
jeevatkm
left a comment
There was a problem hiding this comment.
@BillBuilt Thanks for updating the PR.
|
@BillBuilt Sure, I usually update the go.mod during the release. |
Use crypto/sha256 instead of crypto/md5 for FIPS compliance.
Update deps