Skip to content

feat: add response header argument in EventOpenFunc #1060 #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeevatkm merged 1 commit into from
Nov 26, 2025
Merged

feat: add response header argument in EventOpenFunc #1060 #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type (
// EventOpenFunc is a callback function type used to receive notification
// when Resty establishes a connection with the server for the
// Server-Sent Events(SSE)
EventOpenFunc func(url string)
EventOpenFunc func(url string, respHdr http.Header)

// EventMessageFunc is a callback function type used to receive event details
// from the Server-Sent Events(SSE) stream
Expand Down Expand Up @@ -453,7 +453,7 @@ func (es *EventSource) Get() error {
if err != nil {
return err
}
es.triggerOnOpen()
es.triggerOnOpen(res.Header.Clone())
if err := es.listenStream(res); err != nil {
return err
}
Expand All @@ -479,11 +479,11 @@ func (es *EventSource) isClosed() bool {
return es.closed
}

func (es *EventSource) triggerOnOpen() {
func (es *EventSource) triggerOnOpen(hdr http.Header) {
es.lock.RLock()
defer es.lock.RUnlock()
if es.onOpen != nil {
es.onOpen(strings.Clone(es.url))
es.onOpen(strings.Clone(es.url), hdr)
}
}

Expand Down
8 changes: 4 additions & 4 deletions sse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ func TestEventSourceOverwriteFuncs(t *testing.T) {

es.SetURL(ts.URL).
OnMessage(messageFunc2, nil).
OnOpen(func(url string) {
t.Log("from overwrite func", url)
OnOpen(func(url string, respHdr http.Header) {
t.Log("from overwrite func", url, respHdr)
}).
OnError(func(err error) {
t.Log("from overwrite func", err)
Expand Down Expand Up @@ -422,8 +422,8 @@ func createEventSource(t *testing.T, url string, fn EventMessageFunc, rt any) *E
SetRetryMaxWaitTime(1000 * time.Millisecond).
SetMaxBufSize(1 << 14). // 16kb
SetLogger(createLogger()).
OnOpen(func(url string) {
t.Log("I'm connected:", url)
OnOpen(func(url string, respHdr http.Header) {
t.Log("I'm connected:", url, respHdr)
}).
OnError(func(err error) {
t.Log("Error occurred:", err)
Expand Down