docs(config): clarify realip trust semantics for ipextractionmethod - #3545
Merged
Conversation
Echo's X-Real-IP extractor checks the header value against the trusted ranges, not the peer that sent it, so it cannot report public client IPs. Say so and point users behind a reverse proxy at xff.
github-actions
Bot
added
the
area/config
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-3545
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-3545Last updated for commit dd71ff6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config comments claim X-Real-IP is "only trusted from"
trustedproxiesaddresses. Wrong: echo'srealipextractor checks header value against trusted ranges, not sender, so it never reports public client IPs. Users pickrealip, see loopback/proxy IP in logs, debug for hours (see #3529 discussion, #3539).Comments now say so and point reverse-proxy users at
xff.config.yml.sampleregenerates in CI.